Skip site navigation (1)Skip section navigation (2)
Date:      Thu, 06 Aug 2026 23:21:38 +0000
From:      Kyle Evans <kevans@FreeBSD.org>
To:        src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org
Subject:   git: e55aa7b67cb0 - stable/14 - evdev: use a prometheus-safe label for ev_sysctl_tree
Message-ID:  <6a751702.242b3.7e7a9096@gitrepo.freebsd.org>

index | next in thread | raw e-mail

The branch stable/14 has been updated by kevans:

URL: https://cgit.FreeBSD.org/src/commit/?id=e55aa7b67cb0f7a29a0117231b8764524d1fb971

commit e55aa7b67cb0f7a29a0117231b8764524d1fb971
Author:     Kyle Evans <kevans@FreeBSD.org>
AuthorDate: 2026-06-30 16:51:57 +0000
Commit:     Kyle Evans <kevans@FreeBSD.org>
CommitDate: 2026-08-06 22:53:01 +0000

    evdev: use a prometheus-safe label for ev_sysctl_tree
    
    Prometheus doesn't allow spaces, let's normalize this to what we use
    elsewhere for consistency.  The sysctl exporter could probably do this
    itself, but let's decouple that from the immediate problem: matching the
    label between the exported data and in-tree is nice for greppability.
    
    PR:             296179
    Reviewed by:    asomers, wulf
    
    (cherry picked from commit cb8bda40695f5d402f334f48795b1ab27b72dce5)
---
 sys/dev/evdev/evdev.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/sys/dev/evdev/evdev.c b/sys/dev/evdev/evdev.c
index 87cdaeb91e49..aee482518617 100644
--- a/sys/dev/evdev/evdev.c
+++ b/sys/dev/evdev/evdev.c
@@ -208,7 +208,7 @@ evdev_sysctl_create(struct evdev_dev *evdev)
 	ev_sysctl_tree = SYSCTL_ADD_NODE_WITH_LABEL(&evdev->ev_sysctl_ctx,
 	    SYSCTL_STATIC_CHILDREN(_kern_evdev_input), OID_AUTO,
 	    ev_unit_str, CTLFLAG_RD | CTLFLAG_MPSAFE, NULL, "",
-	    "device index");
+	    "device_index");
 
 	SYSCTL_ADD_STRING(&evdev->ev_sysctl_ctx,
 	    SYSCTL_CHILDREN(ev_sysctl_tree), OID_AUTO, "name", CTLFLAG_RD,


home | help

Want to link to this message? Use this
URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?6a751702.242b3.7e7a9096>