Date: Fri, 23 Jun 2017 23:51:39 +0000 From: Glen Barber <gjb@FreeBSD.org> To: Conrad Meyer <cem@freebsd.org> Cc: Maxim Sobolev <sobomax@freebsd.org>, src-committers <src-committers@freebsd.org>, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r320277 - head/usr.bin/mkuzip Message-ID: <20170623235139.GA69426@FreeBSD.org> In-Reply-To: <CAG6CVpXN2QQVRdqyv5ED3X%2BRCW6sK10_fy9%2BX7hZ8kMRNf=9dA@mail.gmail.com> References: <201706231739.v5NHd05x039900@repo.freebsd.org> <CAG6CVpXN2QQVRdqyv5ED3X%2BRCW6sK10_fy9%2BX7hZ8kMRNf=9dA@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
[-- Attachment #1 --]
On Fri, Jun 23, 2017 at 03:54:35PM -0700, Conrad Meyer wrote:
> > @@ -58,12 +59,15 @@ mkuz_get_insize(struct mkuz_cfg *cfp)
> > ffd = open(statfsbuf.f_mntfromname, O_RDONLY);
> > if (ffd < 0) {
> > warn("open(%s, O_RDONLY)", statfsbuf.f_mntfromname);
> > + close(ffd);
>
> This one is wrong for obvious reasons.
>
It isn't obvious to me. :)
Glen
[-- Attachment #2 --]
-----BEGIN PGP SIGNATURE-----
iQIzBAEBCAAdFiEEjRJAPC5sqwhs9k2jAxRYpUeP4pMFAllNqYYACgkQAxRYpUeP
4pPlWA//bu2hZg+SqiYNZFVN0wahfLRoRfTUX7dXC9gX/UdWx2TXg1mRQ+WLHeQW
dyUwsA2DfxD6CUsmza2UTT6S22VN00TBgMGl9HfbMOTagPt/VO1IkTbLBPdOk95z
zllAJWa/FVdNHIA9ZhpVS1emGCuPivse+wVp22shkg1YEvFBUu3l0qlB2Kgk49LO
1SWmNkkmW8g4EK98d8FwKllV0u/e1gcv8EfdzGqOyH/jsVOGL8zkyup8SJDhPRxg
8F7NpnLSawrTxNXEkd6LIFGAI0m37uNqMpiuJTmjRCjk11VhyJzluPVbFUGCGoDk
9MqjvLhWf2xtzeb7+lMFez2lKoOJRSmJYFddyaCHf8DvAbB530A/9LApOKymG2Vu
T8xIH4YbpLsVTJWvdU6NEFC3MBUkqBkvwnXYaQTc8SIY4uhp0OoGkBbdaH1zIofw
eJOESQ2z0AZ0oS9rus8xY0X2kjUGcrR7gUAJ5GlmBjzVitoj/P44CASLoZgiGnpx
s+UVrtxcnQZN+4HvGGNawdxN5/2Jtr+sbqxQZTz6stnB8DGIuSsAXtrEMAt3GjMJ
BAPt4mULhHL+pMTH0RnX7qAuzplBmxJUzoS52q4+tecj7lwKCT9sS0MCMITUvVmS
NCb5GE5+UMNjlTjNlFlz75I8u63RDZ1LrqqXTAOR1mk5AvbY97I=
=EQVT
-----END PGP SIGNATURE-----
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20170623235139.GA69426>