Skip site navigation (1)Skip section navigation (2)
Date:      Thu, 25 Aug 2016 09:05:53 -0700
From:      Bryan Drewery <bdrewery@FreeBSD.org>
To:        Guido Falsi <madpilot@FreeBSD.org>, Ed Schouten <ed@nuxi.nl>
Cc:        svn-src-head@freebsd.org, jilles@freebsd.org, svn-src-all@freebsd.org, src-committers <src-committers@freebsd.org>, Ed Schouten <ed@freebsd.org>
Subject:   Re: svn commit: r303988 - head/lib/libc/gen
Message-ID:  <f4d148a5-2746-b88a-dd84-28c88de91bde@FreeBSD.org>
In-Reply-To: <2e308383-bfbb-cccd-cfc2-eba63d275f5e@FreeBSD.org>
References:  <201608120703.u7C73whf007189@repo.freebsd.org> <d23b295a-1902-193c-dee6-ba49ebd77280@FreeBSD.org> <9ae1c2eb-02ad-b8fe-6aff-7e17e955607a@FreeBSD.org> <CABh_MKkxD3OTF7VO9Rq_eZyqHPN%2BxVws3q3dsH2R3DfZ343kFw@mail.gmail.com> <2632f5f8-d765-3df7-74d7-da878eb4b7a8@FreeBSD.org> <CABh_MKm_YQ3bJD19Cz1vBCGr=YxuzctXV6F1iqMASkSx-PsVMw@mail.gmail.com> <2e308383-bfbb-cccd-cfc2-eba63d275f5e@FreeBSD.org>

next in thread | previous in thread | raw e-mail | index | archive | help
This is an OpenPGP/MIME signed message (RFC 4880 and 3156)
--VkJaLfGR42nQgrs2CFagxrWlFRQwTQCQB
Content-Type: multipart/mixed; boundary="WukO8iuRMc128b7WokiwhAkMgEIEsnkr6"
From: Bryan Drewery <bdrewery@FreeBSD.org>
To: Guido Falsi <madpilot@FreeBSD.org>, Ed Schouten <ed@nuxi.nl>
Cc: svn-src-head@freebsd.org, jilles@freebsd.org, svn-src-all@freebsd.org,
 src-committers <src-committers@freebsd.org>, Ed Schouten <ed@freebsd.org>
Message-ID: <f4d148a5-2746-b88a-dd84-28c88de91bde@FreeBSD.org>
Subject: Re: svn commit: r303988 - head/lib/libc/gen
References: <201608120703.u7C73whf007189@repo.freebsd.org>
 <d23b295a-1902-193c-dee6-ba49ebd77280@FreeBSD.org>
 <9ae1c2eb-02ad-b8fe-6aff-7e17e955607a@FreeBSD.org>
 <CABh_MKkxD3OTF7VO9Rq_eZyqHPN+xVws3q3dsH2R3DfZ343kFw@mail.gmail.com>
 <2632f5f8-d765-3df7-74d7-da878eb4b7a8@FreeBSD.org>
 <CABh_MKm_YQ3bJD19Cz1vBCGr=YxuzctXV6F1iqMASkSx-PsVMw@mail.gmail.com>
 <2e308383-bfbb-cccd-cfc2-eba63d275f5e@FreeBSD.org>
In-Reply-To: <2e308383-bfbb-cccd-cfc2-eba63d275f5e@FreeBSD.org>

--WukO8iuRMc128b7WokiwhAkMgEIEsnkr6
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: quoted-printable

On 8/25/16 1:27 AM, Guido Falsi wrote:
> On 08/24/16 21:49, Ed Schouten wrote:
>> 2016-08-24 20:30 GMT+02:00 Bryan Drewery <bdrewery@freebsd.org>:
>>> That would only fix stable/11, stable/10, stable/9, releng/11.0.
>>>
>>> It won't fix releng/10.3, releng/10.2, releng/10.1, releng/9.3, etc..=
=2E
>>> without an EN.
>>>
>>> It won't fix stable/11 - 1, stable/10 - 1, etc.
>>>
>>> It will never fix releng/8.4 (unsupported releases) since so@ won't E=
N
>>> to those.  People do sometimes need to build these older releases sti=
ll.
>>>
>>> It creates a line in the sand where we can never build checkouts olde=
r
>>> than where the fix was at.  So I don't think it is the appropriate fi=
x.
>>
>> Good point!
>>
>> Just for the record: Bryan and I just discussed this matter in more
>> detail on IRC. We came up with a workaround that should be pretty
>> good.
>>
>> Attached is a patch for <libgen.h> that adds some extra logic, so that=

>> any calls to basename() and dirname() will expand to calls to
>> __old_basename() and __old_dirname(). Using __sym_compat(), these will=

>> cause the compiler to generate calls to basename@FBSD_1.0 and
>> dirname@FBSD_1.0.
>>
>> According to Bryan, this fixes the problems he was experiencing.
>>
>=20
> I just tried using the attached patch to build a nanobsd image, host is=

> amd64 head at r304773 with this patch applied, target is i386
> releng/11.0 at r304729.
>=20

What did you apply the patch to?

You need to apply to the source tree, then do a buildworld/installworld
for the host, then try nanobsd.

> I've got it failing early during build:
>=20
> --- _bootstrap-tools-usr.bin/xinstall ---
> xinstall.o: In function `install':
> /usr/local/nanobsd/rr-trunk/src/usr.bin/xinstall/xinstall.c:(.text+0xf5=
5):
> undefined reference to `basename@FBSD_1.0'
> cc: error: linker command failed with exit code 1 (use -v to see invoca=
tion)
> *** [xinstall] Error code 1
>=20
> make[3]: stopped in /usr/local/nanobsd/rr-trunk/src/usr.bin/xinstall
> 1 error
>=20
> make[3]: stopped in /usr/local/nanobsd/rr-trunk/src/usr.bin/xinstall
> *** [_bootstrap-tools-usr.bin/xinstall] Error code 2
>=20
> Did I miss some needed procedure?
>=20
> Thanks!
>=20


--=20
Regards,
Bryan Drewery


--WukO8iuRMc128b7WokiwhAkMgEIEsnkr6--

--VkJaLfGR42nQgrs2CFagxrWlFRQwTQCQB
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: OpenPGP digital signature
Content-Disposition: attachment; filename="signature.asc"

-----BEGIN PGP SIGNATURE-----
Comment: GPGTools - https://gpgtools.org

iQEcBAEBCgAGBQJXvxdhAAoJEDXXcbtuRpfPaLAIAM+EIb288iIk4lkdaP0zHYXS
HAa4H+UpjLdvqfUu78t82Cqw4uC10oo8YSoAR1MzdTIDoC9cQCVmhasdaaiL5aVc
rAWb3gWqWgeoz3reVyn/zovPQ5+F0FvgYDFnf/RRq8WBIdjQJDtig1NARru7sMvB
bsY25F7p2XQaTI/uC4/m80GpjQkY14UniKD0GfAW8U/DT1QPnfA0ec7P9hT5IqHF
/+F13fAmqUzpOxHQXWTRmifRfvyxAB2uXBswEF4WsXm+v8LkS8DYtxkrUyzLrq/E
DDguInPVPfhVo5GzOmluAZ7QbRlqrc2wx5rO6N4E5r8m9E3AgLetlUKFpvfzN4U=
=C/Ig
-----END PGP SIGNATURE-----

--VkJaLfGR42nQgrs2CFagxrWlFRQwTQCQB--



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?f4d148a5-2746-b88a-dd84-28c88de91bde>