Skip site navigation (1)Skip section navigation (2) 
Date:      Fri, 30 Mar 2012 15:30:45 +0200
From:      Stefan Farfeleder <stefanf@FreeBSD.org>
To:        David Xu <davidxu@FreeBSD.org>
Cc:        svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org
Subject:   Re: svn commit: r233700 - head/sys/kern
Message-ID:  <20120330133045.GD1423@mole.fafoe.narf.at>
In-Reply-To: <201203301257.q2UCvE4l042042@svn.freebsd.org>
References:  <201203301257.q2UCvE4l042042@svn.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help 

--huq684BweRXVnRxX
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

Hi,

here are a few similar cases.

Stefan

--huq684BweRXVnRxX
Content-Type: text/x-diff; charset=us-ascii
Content-Disposition: attachment; filename="extra-semicolon-if.diff"

Index: tools/regression/lib/libc/nss/test-gethostby.c
===================================================================
--- tools/regression/lib/libc/nss/test-gethostby.c	(revision 233700)
+++ tools/regression/lib/libc/nss/test-gethostby.c	(working copy)
@@ -109,7 +109,7 @@
 	else {
 		error = 0;
 		he = getipnodebyname(name, af, ipnode_flags, &error);
-		if (he == NULL);
+		if (he == NULL)
 			errno = error;
 	}
 	
Index: cddl/compat/opensolaris/misc/deviceid.c
===================================================================
--- cddl/compat/opensolaris/misc/deviceid.c	(revision 233700)
+++ cddl/compat/opensolaris/misc/deviceid.c	(working copy)
@@ -45,7 +45,7 @@
 		return (EINVAL);
 	}
 	*retminor_name = strdup("");
-	if (*retminor_name == NULL);
+	if (*retminor_name == NULL)
 		return (ENOMEM);
 	return (0);
 }
Index: sys/sparc64/pci/fire.c
===================================================================
--- sys/sparc64/pci/fire.c	(revision 233700)
+++ sys/sparc64/pci/fire.c	(working copy)
@@ -446,7 +446,7 @@
 		    FO_PCI_TLU_CTRL_CFG_MASK) >> FO_PCI_TLU_CTRL_CFG_SHFT;
 		i = sizeof(fire_freq_nak_tmr_thrs) /
 		    sizeof(*fire_freq_nak_tmr_thrs);
-		if (mps >= i);
+		if (mps >= i)
 			mps = i - 1;
 		FIRE_PCI_SET(sc, FO_PCI_LPU_TXLNK_FREQ_LAT_TMR_THRS,
 		    (fire_freq_nak_tmr_thrs[mps][lw] <<
Index: sys/contrib/rdma/rdma_addr.c
===================================================================
--- sys/contrib/rdma/rdma_addr.c	(revision 233700)
+++ sys/contrib/rdma/rdma_addr.c	(working copy)
@@ -172,7 +172,7 @@
 	*dst = *dst_in;
 
 	rtalloc(&iproute);
-	if (iproute.ro_rt == NULL);
+	if (iproute.ro_rt == NULL)
 		return;
 
 	arpresolve(iproute.ro_rt->rt_ifp, iproute.ro_rt, NULL, 
Index: sys/dev/gpio/gpioc.c
===================================================================
--- sys/dev/gpio/gpioc.c	(revision 233700)
+++ sys/dev/gpio/gpioc.c	(working copy)
@@ -102,7 +102,7 @@
 	struct gpioc_softc *sc = device_get_softc(dev);
 	int err;
 
-	if (sc->sc_ctl_dev);
+	if (sc->sc_ctl_dev)
 		destroy_dev(sc->sc_ctl_dev);
 
 	if ((err = bus_generic_detach(dev)) != 0)

--huq684BweRXVnRxX--

Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20120330133045.GD1423>