Date: Sat, 27 Jan 2018 21:08:01 +0100 From: Emmanuel Vadot <manu@bidouilliste.com> To: "Poul-Henning Kamp" <phk@phk.freebsd.dk> Cc: Warner Losh <imp@bsdimp.com>, John Baldwin <jhb@freebsd.org>, Ravi Pokala <rpokala@mac.com>, src-committers <src-committers@freebsd.org>, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r328257 - in head/sys: arm/broadcom/bcm2835 dts/arm modules Message-ID: <20180127210801.37b8001125dd0a2c92372f98@bidouilliste.com> In-Reply-To: <93949.1516733748@critter.freebsd.dk> References: <201801220710.w0M7AUm9091853@repo.freebsd.org> <CANCZdfpq2QoG4EAj0VW2FF=4VXRv-qQKFfJTJerWH9YOwVoVBA@mail.gmail.com> <90451.1516663240@critter.freebsd.dk> <2987003.eeGRFBb6N8@ralph.baldwin.cx> <CANCZdfrh0NHq7cbkq_genEdzo%2BB3G4TTAcEzpgh11sr%2B82e9aw@mail.gmail.com> <93949.1516733748@critter.freebsd.dk>
next in thread | previous in thread | raw e-mail | index | archive | help
So, almost a week after this commit, let's recap.
- phk@ commit an hack to allow the pwm driver on rpi to always attach
even if it's not enabled in the dts.
- I say to him that it's a really bad move and that he should use dtb
overlays (which thanks to kevans@ are in a really better state now).
- His answer is that as long as you don't set the pwm sysctls you will
be fine (which is true) and that he want to be able to load dtb
overlays without rebooting (or a way to modify the existing dtb loaded
in the kernel).
- I reply that changing the dtb should go with overlays and that
nobody is working on loading overlays at runtime.
- His reply starts with "That doesn't make *any* UX sense."
- The "problem" is we (FreeBSD) choose to followed the standard that is
Flattened Device Tree and stick to it for arm (at least) platform.
- phk@ says that if a user kldload the pwm driver on a rpi the pwm
subsystem should be in a usable state. And doesn't want to talk anymore
("Over&Out).
- jhb@ and imp@ talk about ways to improve the fdt subsystem.
- ian@ point to phk@ that the 'status' line in the dts control more
than a device but also pinmuxing (switching pins on the SoC to the
correct function) and that is it done at startup and not at the driver
attach. And that the rpi platform needs some love as it doesn't have a
proper pinmux driver.
- phk@ points out that there is no doc about doing a pinmux driver
(which is true, unless you consider code as documentation or even
help/advice from other arm developpers).
But.
- We still have this driver that doesn't follow the standard we said we
want to adhere to.
- Nobody except me explicitly request phk@ to revert his commit (which
he didn't do).
- One day after everything was back to normal and everybody forgot
about this.
So.
- We have a commiter that commited something for his own need: he
wanted to use the pwm on his rpi, coded a driver (this part is good)
but feel that the standard we were using was crap and commited his work
without talking with arm developper on what the proper way to do it was.
- Even after some developpers point out that it wasn't the way to go
he didn't revert his commit. And even he didn't say that he won't, his
mail suggest that he will not.
- Now we have a crappy driver in the tree.
What's next ?
Cheers,
--
Emmanuel Vadot <manu@bidouilliste.com> <manu@freebsd.org>
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20180127210801.37b8001125dd0a2c92372f98>