Date: Fri, 4 Apr 2003 20:10:34 +1000 (EST) From: Bruce Evans <bde@zeta.org.au> To: "David O'Brien" <obrien@FreeBSD.org> Cc: Marcel Moolenaar <marcel@xcllnt.net> Subject: Re: cvs commit: src/libexec/talkd announce.c extern.h print.ctable.c talkd.c Message-ID: <20030404200159.J33842@gamplex.bde.org> In-Reply-To: <20030403155917.GC17860@dragon.nuxi.com> References: <200304030513.h335DR60079544@repoman.freebsd.org> <20030403055049.GA67232@dhcp01.pn.xcllnt.net> <20030403085350.GA37174@sunbay.com> <20030403155917.GC17860@dragon.nuxi.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On Thu, 3 Apr 2003, David O'Brien wrote:
> On Thu, Apr 03, 2003 at 11:53:50AM +0300, Ruslan Ermilov wrote:
> > -. if ${WARNS} > 4
> > +. if ${WARNS} > 4 && !empty(CFLAGS:M-O*) && empty(CFLAGS:M-O0)
> > CFLAGS += -Wuninitialized
> > . endif
>
> Why not just get rid of it totally? We have this already:
It's too useful to remove totally.
> . if ${WARNS} > 1 && ${WARNS} < 5
> # XXX Delete -Wuninitialized by default for now -- the compiler doesn't
> # XXX always get it right.
> CFLAGS += -Wno-uninitialized
> . endif
>
> so we already know it is problematic. OR rather than use:
>
> . if ${WARNS} > 4
> CFLAGS += -Wuninitialized
> . endif
>
> use
>
> . if ${WARNS} == 4
> CFLAGS += -Wuninitialized
> . endif
Add -Wno-uninitialized to cancel -Wuninitialized being part of -Wall as
necessary, i.e., if -Wall is added (${WARNS} > 1) but -O is not in ${CFLAGS}.
Don't add it or change WARNS settings back and forth to work around bitrot
from -Wuninitialized not being turned off for so long. Don't change sources
"to keep gcc happy".
Bruce
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20030404200159.J33842>