Skip site navigation (1)Skip section navigation (2)
Date:      Thu, 6 Jun 2019 17:20:35 +0000 (UTC)
From:      Mark Johnston <markj@FreeBSD.org>
To:        src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org
Subject:   svn commit: r348751 - head/sys/net
Message-ID:  <201906061720.x56HKZ1o003922@repo.freebsd.org>

next in thread | raw e-mail | index | archive | help
Author: markj
Date: Thu Jun  6 17:20:35 2019
New Revision: 348751
URL: https://svnweb.freebsd.org/changeset/base/348751

Log:
  Restore the comment removed in r348745.
  
  LAGG_RLOCK() enters an epoch section, so the comment wasn't stale.
  
  Reported by:	jhb
  MFC with:	r348745

Modified:
  head/sys/net/if_lagg.c

Modified: head/sys/net/if_lagg.c
==============================================================================
--- head/sys/net/if_lagg.c	Thu Jun  6 16:29:08 2019	(r348750)
+++ head/sys/net/if_lagg.c	Thu Jun  6 17:20:35 2019	(r348751)
@@ -1956,6 +1956,10 @@ lagg_link_active(struct lagg_softc *sc, struct lagg_po
 	 */
 
 #ifdef INVARIANTS
+	/*
+	 * This is called with either LAGG_RLOCK() held or
+	 * LAGG_XLOCK(sc) held.
+	 */
 	if (!in_epoch(net_epoch_preempt))
 		LAGG_XLOCK_ASSERT(sc);
 #endif



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201906061720.x56HKZ1o003922>