Date: Sun, 23 Dec 2012 21:17:05 +0100 From: Pawel Jakub Dawidek <pjd@FreeBSD.org> To: Matthew Seaman <matthew@FreeBSD.org> Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r244608 - head/usr.sbin/pkg Message-ID: <20121223201704.GA1436@garage.freebsd.pl> In-Reply-To: <201212231122.qBNBMIXb081427@svn.freebsd.org> References: <201212231122.qBNBMIXb081427@svn.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
--GvXjxJ+pjyke8COw Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sun, Dec 23, 2012 at 11:22:18AM +0000, Matthew Seaman wrote: > Author: matthew (ports committer) > Date: Sun Dec 23 11:22:18 2012 > New Revision: 244608 > URL: http://svnweb.freebsd.org/changeset/base/244608 >=20 > Log: > Third time's the charm. pkg -N output needs to go to stderr. > =20 > Approved by: bapt > MFC after: 2 weeks >=20 > Modified: > head/usr.sbin/pkg/pkg.c >=20 > Modified: head/usr.sbin/pkg/pkg.c > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D > --- head/usr.sbin/pkg/pkg.c Sun Dec 23 10:21:01 2012 (r244607) > +++ head/usr.sbin/pkg/pkg.c Sun Dec 23 11:22:18 2012 (r244608) > @@ -457,10 +457,8 @@ main(__unused int argc, char *argv[]) > * a system is configured to use pkg, don't bootstrap pkg > * when that argument is given as argv[1]. > */ > - if ( argv[1] !=3D NULL && strcmp(argv[1], "-N") =3D=3D 0) { > - printf("%s", "pkg is not installed\n"); > - exit(EXIT_FAILURE); > - } > + if ( argv[1] !=3D NULL && strcmp(argv[1], "-N") =3D=3D 0) > + errx(EXIT_FAILURE, "pkg is not installed\n"); How about removing space after 'if (' and redundant '\n'? --=20 Pawel Jakub Dawidek http://www.wheelsystems.com FreeBSD committer http://www.FreeBSD.org Am I Evil? Yes, I Am! http://tupytaj.pl --GvXjxJ+pjyke8COw Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.19 (FreeBSD) iEYEARECAAYFAlDXZsAACgkQForvXbEpPzRe5wCg42/xjBdDW5A8RfMtZJ8lC/Kc dEMAn35bdDpB75F37yPapW6VthHLHyui =mGC+ -----END PGP SIGNATURE----- --GvXjxJ+pjyke8COw--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20121223201704.GA1436>