Date: Thu, 24 Oct 2019 02:28:28 +0000 (UTC) From: Kyle Evans <kevans@FreeBSD.org> To: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-stable@freebsd.org, svn-src-stable-12@freebsd.org Subject: svn commit: r353972 - stable/12/stand/i386/libfirewire Message-ID: <201910240228.x9O2SSCN081603@repo.freebsd.org>
next in thread | raw e-mail | index | archive | help
Author: kevans Date: Thu Oct 24 02:28:28 2019 New Revision: 353972 URL: https://svnweb.freebsd.org/changeset/base/353972 Log: MFC r342865: biospci_write_config args were backwards biospci_write_config args swapped length and value to write. Some hardware coped just fine, while other hardware had issues. PR: 155441 Modified: stable/12/stand/i386/libfirewire/firewire.c Directory Properties: stable/12/ (props changed) Modified: stable/12/stand/i386/libfirewire/firewire.c ============================================================================== --- stable/12/stand/i386/libfirewire/firewire.c Thu Oct 24 02:27:16 2019 (r353971) +++ stable/12/stand/i386/libfirewire/firewire.c Thu Oct 24 02:28:28 2019 (r353972) @@ -107,9 +107,9 @@ fw_probe(int index, struct fwohci_softc *sc) } biospci_write_config(sc->locator, - 0x4 /* command */, - 0x6 /* enable bus master and memory mapped I/O */, - BIOSPCI_16BITS); + 0x4 /* command */, + BIOSPCI_16BITS, + 0x6 /* enable bus master and memory mapped I/O */); biospci_read_config(sc->locator, 0x00 /*devid*/, BIOSPCI_32BITS, &sc->devid);
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201910240228.x9O2SSCN081603>