Date: Mon, 20 Feb 2006 19:46:24 -0800 From: Maksim Yevmenkin <maksim.yevmenkin@savvis.net> To: Markus Brueffer <markus@brueffer.de> Cc: freebsd-bluetooth@freebsd.org Subject: Re: hccontrol and BT 1.2 updates Message-ID: <43FA8D10.3050500@savvis.net> In-Reply-To: <200602201321.30218.markus@brueffer.de> References: <200602201321.30218.markus@brueffer.de>
next in thread | previous in thread | raw e-mail | index | archive | help
Markus, > I just wanted to let you know what I'm currently working on (to not double > efforts): wow! this is some great stuff here. thanks! > Updated ng_hci.h for bluetooth 1.2: > http://people.freebsd.org/~markus/bt/ng_hci.h.diff i briefly looked at this and it looks fine to me. i have just one minor comment. you have re-named NG_HCI_OCF_{READ,WRITE}_PAGE_SCAN_PERIOD and NG_HCI_OCF_{READ,WRITE}_PAGE_SCAN commands. i guess, you have done this so the freebsd name matches the bluetooth name. that is fine. i have no objections to this, but we also need to rename these commands in other places, i.e. /usr/src/usr.sbin/bluetooth/hccontrol/host_controller_baseband.c /usr/src/sys/netgraph/bluetooth/hci/ng_hci_cmds.c /usr/src/sys/netgraph/bluetooth/socket/ng_btsocket_hci_raw.c there might be other places i have missed. could you please do a full buildworld and buildkernel with this patch applied to find all places and rename them as well? provided this, i think, it should be committed to -current (but please do not mfc it just yet). if there are no problems please mfc it in a couple of months or so. > Updated hccontrol with updated vendor list, feature reporting including > bluetooth v1.2 and v2.0 and updated version strings for HCI and LMP according > to the official description: > http://people.freebsd.org/~markus/bt/hccontrol.diff this looks fine. to my taste, it has some extra verbosity, i.e. HCI version: Bluetooth HCI Specification 2.0 [0x3] LMP version: Bluetooth LMP 2.0 [0x3] but, again, its just me. > The latter one reports versions and features on a Belkin BT 2.0 dongle as > follows: > http://people.freebsd.org/~markus/bt/bt20features.txt looks great! > I think, at least the version reporting part and the updated vendor list could > be added to our current hccontrol. agreed. please commit and mfc it to releng_6,5. > I'm currently thinking about incorporating libhci, which I'm currently > writing, into libbluetooth, like the bluez people do since recently and would > like the future hccontrol to be based on it where possible. Any thoughts? i looked at the code in your home directory on freefall. is this the latest version? also, i think you should go ahead and start committing libhci(3) code. once its done, hccontrol(8) should be converted to use libhci(3). i have your request to include support for bluetooth device enumeration and will try to implement it soon. is there anything else we need for libhci(3)? keep up the good work! thanks, max
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?43FA8D10.3050500>