Date: Sat, 25 Apr 2020 12:39:29 +0000 (UTC) From: Dimitry Andric <dim@FreeBSD.org> To: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-stable@freebsd.org, svn-src-stable-11@freebsd.org Subject: svn commit: r360297 - in stable: 11/sys/dev/ips 12/sys/dev/ips Message-ID: <202004251239.03PCdTFb057053@repo.freebsd.org>
next in thread | raw e-mail | index | archive | help
Author: dim Date: Sat Apr 25 12:39:28 2020 New Revision: 360297 URL: https://svnweb.freebsd.org/changeset/base/360297 Log: MFC r348366 (by lwhsu): Add the likely missing braces in ips(4). This is found by gcc warning that the code is not guarded by the if clause and has misleading indentation. Approved by: scottl Sponsored by: The FreeBSD Foundation Differential Revision: https://reviews.freebsd.org/D20427 Modified: stable/11/sys/dev/ips/ips.c Directory Properties: stable/11/ (props changed) Changes in other areas also in this revision: Modified: stable/12/sys/dev/ips/ips.c Directory Properties: stable/12/ (props changed) Modified: stable/11/sys/dev/ips/ips.c ============================================================================== --- stable/11/sys/dev/ips/ips.c Sat Apr 25 11:35:38 2020 (r360296) +++ stable/11/sys/dev/ips/ips.c Sat Apr 25 12:39:28 2020 (r360297) @@ -281,10 +281,11 @@ static int ips_diskdev_free(ips_softc_t *sc) int i; int error = 0; for(i = 0; i < IPS_MAX_NUM_DRIVES; i++){ - if(sc->diskdev[i]) + if(sc->diskdev[i]) { error = device_delete_child(sc->dev, sc->diskdev[i]); if(error) return error; + } } bus_generic_detach(sc->dev); return 0;
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?202004251239.03PCdTFb057053>