Date: Thu, 20 Dec 2007 13:46:55 -0500 From: John Baldwin <jhb@freebsd.org> To: freebsd-hackers@freebsd.org Cc: hackers@freebsd.org Subject: Re: Some diffs Message-ID: <200712201346.55717.jhb@freebsd.org> In-Reply-To: <20071219.232511.-1548301831.imp@bsdimp.com> References: <20071219.232511.-1548301831.imp@bsdimp.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On Thursday 20 December 2007 01:25:11 am M. Warner Losh wrote:
> Consider the following diffs. The first one does a tiny cleanup of
> strfile's include style (no real reason other than it bugged me when I
> added stdint.h).
>
> The second one cleans up a minor problem where ${CFLAGS} isn't used
> where it should be.
>
> The next three cleanup the compilation by not assuming sys/types.h is
> included or by also including <stdint.h>
These all seem fine to me.
> And the last, rather long, patch converts the .y in config to a form
> that more versions of yacc would grok.
I have no yacc-clue.
> Comments?
Was the bsd.prog.mk change accidentally included?
> ==== //depot/projects/arm/src/share/mk/bsd.prog.mk#4 - /Users/imp/p4/arm/src/share/mk/bsd.prog.mk ====
> @@ -110,17 +110,18 @@
>
> .if defined(PROG)
> _EXTRADEPEND:
> -.if defined(LDFLAGS) && !empty(LDFLAGS:M-nostdlib)
> +.if !defined(FOREIGN_BUILD)
> .if defined(DPADD) && !empty(DPADD)
> echo ${PROG}: ${DPADD} >> ${DEPENDFILE}
> .endif
> -.else
> +.if defined(LDFLAGS) && !empty(LDFLAGS:M-nostdlib)
> echo ${PROG}: ${LIBC} ${DPADD} >> ${DEPENDFILE}
> .if defined(PROG_CXX)
> echo ${PROG}: ${LIBSTDCPLUSPLUS} >> ${DEPENDFILE}
> .endif
> .endif
> .endif
> +.endif
>
> .if !target(install)
--
John Baldwin
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200712201346.55717.jhb>