Skip site navigation (1)Skip section navigation (2)
Date:      Mon, 4 Aug 2014 00:51:57 +0000 (UTC)
From:      Pedro F. Giffuni <pfg@FreeBSD.org>
To:        src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-stable@freebsd.org, svn-src-stable-10@freebsd.org
Subject:   svn commit: r269491 - stable/10/lib/libc/stdlib
Message-ID:  <53ded92d.5d30.24eb2c6b@svn.freebsd.org>

next in thread | raw e-mail | index | archive | help
Author: pfg
Date: Mon Aug  4 00:51:57 2014
New Revision: 269491
URL: http://svnweb.freebsd.org/changeset/base/269491

Log:
  MFC	r268945:
  Fix hdestroy() compliance issue.
  
  The hcreate(3) implementation and related functions we inherited
  from NetBSD used to free() the key value, something that is not
  supported by the standard implementation.
  
  This would cause a segmentation fault when attempting to run
  the examples from the opengroup and linux manpages.
  
  There is no need to bump the __FreeBSD_version as we have
  always claimed XPG4.2 compliance but if some reference is
  required, the bump for r269484 can be used.
  
  Reference:
  http://bugs.dragonflybsd.org/issues/1398

Modified:
  stable/10/lib/libc/stdlib/hcreate.c
Directory Properties:
  stable/10/   (props changed)

Modified: stable/10/lib/libc/stdlib/hcreate.c
==============================================================================
--- stable/10/lib/libc/stdlib/hcreate.c	Sun Aug  3 22:59:47 2014	(r269490)
+++ stable/10/lib/libc/stdlib/hcreate.c	Mon Aug  4 00:51:57 2014	(r269491)
@@ -142,7 +142,6 @@ hdestroy(void)
 		while (!SLIST_EMPTY(&htable[idx])) {
 			ie = SLIST_FIRST(&htable[idx]);
 			SLIST_REMOVE_HEAD(&htable[idx], link);
-			free(ie->ent.key);
 			free(ie);
 		}
 	}



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?53ded92d.5d30.24eb2c6b>