Skip site navigation (1)Skip section navigation (2)
Date:      Wed, 26 Apr 2023 10:45:44 -0400
From:      Mark Johnston <markj@freebsd.org>
To:        Hans Petter Selasky <hps@selasky.org>
Cc:        src-committers@freebsd.org, dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org
Subject:   Re: git: 78cfa762ebf2 - main - callout: Move per-CPU callout state into the dpcpu region
Message-ID:  <ZEk5GHk1tIGpkTW9@nuc>
In-Reply-To: <d0e16a27-4faa-4eae-6553-eaf09d576074@selasky.org>
References:  <202304261413.33QEDxBD086666@gitrepo.freebsd.org> <d0e16a27-4faa-4eae-6553-eaf09d576074@selasky.org>

next in thread | previous in thread | raw e-mail | index | archive | help
On Wed, Apr 26, 2023 at 04:42:06PM +0200, Hans Petter Selasky wrote:
> On 4/26/23 16:13, Mark Johnston wrote:
> > -	mtx_init(&cc->cc_lock, "callout", NULL, MTX_SPIN);
> > +	mtx_init(&cc->cc_lock, "callout", NULL, MTX_SPIN | MTX_NEW);
> 
> Is the MTX_NEW needed? Shouldn't the DCPU memory be zeroed by default?

I think you are right, it shouldn't be needed.  I'll retest without it.



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?ZEk5GHk1tIGpkTW9>