Date: Sat, 26 Jul 2003 00:19:02 +0300 From: Ruslan Ermilov <ru@FreeBSD.org> To: "David O'Brien" <obrien@FreeBSD.org> Cc: cvs-all@FreeBSD.org Subject: Re: cvs commit: src/release Makefile src/share/man/man7 release.7 Message-ID: <20030725211902.GE34677@sunbay.com> In-Reply-To: <20030725162952.GC37608@dragon.nuxi.com> References: <200307250854.h6P8sfom098536@repoman.freebsd.org> <20030725.213123.74673434.nyan@jp.FreeBSD.org> <20030725130041.GA84040@sunbay.com> <20030725162952.GC37608@dragon.nuxi.com>
next in thread | previous in thread | raw e-mail | index | archive | help
[-- Attachment #1 --]
On Fri, Jul 25, 2003 at 09:29:52AM -0700, David O'Brien wrote:
> On Fri, Jul 25, 2003 at 04:00:41PM +0300, Ruslan Ermilov wrote:
> > Index: Makefile
> > ===================================================================
> > RCS file: /home/ncvs/src/release/Makefile,v
> > retrieving revision 1.798
> > diff -u -r1.798 Makefile
> > --- Makefile 25 Jul 2003 08:55:51 -0000 1.798
> > +++ Makefile 25 Jul 2003 12:58:42 -0000
> > @@ -1087,7 +1087,11 @@
> > @echo "echo Please insert MFS root floppy and press enter:" >> ${RD}/image.${FSIMAGE}/boot/loader.rc
> > @echo "read" >> ${RD}/image.${FSIMAGE}/boot/loader.rc
> > .endif
> > +.if defined(FDSIZE) && ${FDSIZE} == "SMALL"
> > + @echo "load -t mfs_root /mfsroot-small" >> ${RD}/image.${FSIMAGE}/boot/loader.rc
> > +.else
> > @echo "load -t mfs_root /mfsroot" >> ${RD}/image.${FSIMAGE}/boot/loader.rc
> > +.endif
>
> Can we *PLEASE* stop this .ifdef maze? Why not set ${MFSROOT_NAME} much
> higher up and have a single
> @echo "load -t mfs_root ${MFSROOT_NAME}" >> ${RD}/image.${FSIMAGE}/boot/loader.rc
>
Feel free to.
Cheers,
--
Ruslan Ermilov Sysadmin and DBA,
ru@sunbay.com Sunbay Software Ltd,
ru@FreeBSD.org FreeBSD committer
[-- Attachment #2 --]
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.1 (FreeBSD)
iD8DBQE/IZ7GUkv4P6juNwoRAmdQAJ9ACCOSwVacba2QUXXB83dMhiF+YwCeNgOu
W1/Gl6t/oULT3J1v4z1PoWo=
=rjBe
-----END PGP SIGNATURE-----
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20030725211902.GE34677>