Date: Tue, 16 Oct 2018 07:39:32 +0200 From: Antoine Brodin <antoine@freebsd.org> To: Ed Maste <emaste@freebsd.org> Cc: Gerald Pfeifer <gerald@freebsd.org>, re <re@freebsd.org>, src-committers <src-committers@freebsd.org>, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r339350 - head/contrib/elftoolchain/elfcopy Message-ID: <CAALwa8=rUZh=VaQL0Ln6TsrfaK7maAhdG88AD1ZyDc-UpDMxSQ@mail.gmail.com> In-Reply-To: <CAPyFy2B-Oc8rVk_iBd8z6ecK_htEF41CCEZ_9=29zMGwap5aKg@mail.gmail.com> References: <201810132126.w9DLQ73C022496@repo.freebsd.org> <CAALwa8k5k7T2Xy6jSq0bbj%2Biq0T_FwctOZ-=ZLkCU6eS1%2BCoKg@mail.gmail.com> <CAPyFy2Cv2ydYWmBvWxoM9ACw2iCnq7xfsngEyOPF7XNK7P8ckA@mail.gmail.com> <CAPyFy2B-Oc8rVk_iBd8z6ecK_htEF41CCEZ_9=29zMGwap5aKg@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
--0000000000001b5a93057851fb83
Content-Type: text/plain; charset="UTF-8"
On Mon, Oct 15, 2018 at 3:53 PM Ed Maste <emaste@freebsd.org> wrote:
> On Mon, 15 Oct 2018 at 07:13, Ed Maste <emaste@freebsd.org> wrote:
> > Hi Antoine, did you bisect to this rev or does it just look like the
> > most probable candidate? Can you copy a pair of differing .o files
> > (say, gcc/cc1plus-checksum.o) from the work dir to freefall?
>
> Antoine provided a tarball of the work dir to me, and pointed out that
> the *-checksum.o files are not interesting - they are warnings only
> and are present prior to the identified change.
>
> Comparing one of the other differing files, e.g.
> stage{2,3}-gcc/expmed.o, demonstrates the problem. Gcc's build
> machinery is reasonably obfuscated so I'm not sure of the exact set of
> operations, but I can infer that the stage2/stage3 comparison is
> running strip on the object files and then comparing the result. Gcc
> is encountering this part of my strip/objcopy change:
>
> > Stripping binaries with relocations
> > referencing removed symbols was already broken, and after this change
> > may still be broken in a different way.
>
> Stripping symbols and relocations from an object file is not a
> particularly useful operation, since the object then can't be linked
> or otherwise used. But it seems Gcc's stage comparison relies on this.
> I did try running "strip --strip-debug" on stage{2,3}-gcc/expmed.o (a
> reasonable operation on object files) and that produced identical
> output.
>
> It may well be that a further change to ELF Tool Chain's strip is
> warranted, but I suspect the most straightforward and reliable fix
> here will be to just have gcc use GNU strip.
The attached patch for the gcc ports fixes the failures for me.
Antoine
--0000000000001b5a93057851fb83
Content-Type: text/x-patch; charset="US-ASCII"; name="gcc-strip.diff"
Content-Disposition: attachment; filename="gcc-strip.diff"
Content-Transfer-Encoding: base64
Content-ID: <f_jnbarwaf0>
X-Attachment-Id: f_jnbarwaf0
SW5kZXg6IGxhbmcvZ2NjNDgvTWFrZWZpbGUKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gbGFuZy9nY2M0OC9NYWtl
ZmlsZQkocmV2aXNpb24gNDgyMTY1KQorKysgbGFuZy9nY2M0OC9NYWtlZmlsZQkod29ya2luZyBj
b3B5KQpAQCAtMzMsNiArMzMsNyBAQAogU1VGRklYPQkJJHtQT1JUVkVSU0lPTjpDLyhbMC05XSsp
LihbMC05XSspLiovXDFcMi99CiBVU0VTPQkJY29tcGlsZXIgY3BlIGdtYWtlIGljb252IGxpYnRv
b2wgbWFrZWluZm8gcGVybDUgdGFyOmJ6aXAyCiBVU0VfQklOVVRJTFM9CXllcworQklOQVJZX0FM
SUFTPQlzdHJpcD0ke0xPQ0FMQkFTRX0vYmluL3N0cmlwCiBVU0VfUEVSTDU9CWJ1aWxkCiBTU1Bf
VU5TQUZFPQl5ZXMKIApJbmRleDogbGFuZy9nY2M0OS9NYWtlZmlsZQo9PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBs
YW5nL2djYzQ5L01ha2VmaWxlCShyZXZpc2lvbiA0ODIxNjUpCisrKyBsYW5nL2djYzQ5L01ha2Vm
aWxlCSh3b3JraW5nIGNvcHkpCkBAIC0zMyw2ICszMyw3IEBACiBTVUZGSVg9CQkke1BPUlRWRVJT
SU9OOkMvKFswLTldKykuKFswLTldKykuKi9cMVwyL30KIFVTRVM9CQljb21waWxlciBjcGUgZ21h
a2UgaWNvbnYgbGlidG9vbCBtYWtlaW5mbyBwZXJsNSB0YXI6YnppcDIKIFVTRV9CSU5VVElMUz0J
eWVzCitCSU5BUllfQUxJQVM9CXN0cmlwPSR7TE9DQUxCQVNFfS9iaW4vc3RyaXAKIFVTRV9QRVJM
NT0JYnVpbGQKIFNTUF9VTlNBRkU9CXllcwogCkluZGV4OiBsYW5nL2djYzUvTWFrZWZpbGUKPT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PQotLS0gbGFuZy9nY2M1L01ha2VmaWxlCShyZXZpc2lvbiA0ODIxNjUpCisrKyBsYW5n
L2djYzUvTWFrZWZpbGUJKHdvcmtpbmcgY29weSkKQEAgLTM0LDYgKzM0LDcgQEAKIFNVRkZJWD0J
CSR7UE9SVFZFUlNJT046Qy8oWzAtOV0rKS4qL1wxL30KIFVTRVM9CQljb21waWxlciBjcGUgZ21h
a2UgaWNvbnYgbGlidG9vbCBtYWtlaW5mbyBwZXJsNSB0YXI6eHoKIFVTRV9CSU5VVElMUz0JeWVz
CitCSU5BUllfQUxJQVM9CXN0cmlwPSR7TE9DQUxCQVNFfS9iaW4vc3RyaXAKIFVTRV9QRVJMNT0J
YnVpbGQKIFNTUF9VTlNBRkU9CXllcwogCkluZGV4OiBsYW5nL2djYzYvTWFrZWZpbGUKPT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PQotLS0gbGFuZy9nY2M2L01ha2VmaWxlCShyZXZpc2lvbiA0ODIxNjUpCisrKyBsYW5nL2dj
YzYvTWFrZWZpbGUJKHdvcmtpbmcgY29weSkKQEAgLTM1LDYgKzM1LDcgQEAKIFNVRkZJWD0JCSR7
UE9SVFZFUlNJT046Qy8oWzAtOV0rKS4qL1wxL30KIFVTRVM9CQljb21waWxlciBjcGUgZ21ha2Ug
aWNvbnYgbGlidG9vbCBtYWtlaW5mbyBwZXJsNSB0YXI6eHoKIFVTRV9CSU5VVElMUz0JeWVzCitC
SU5BUllfQUxJQVM9CXN0cmlwPSR7TE9DQUxCQVNFfS9iaW4vc3RyaXAKIFVTRV9QRVJMNT0JYnVp
bGQKIFNTUF9VTlNBRkU9CXllcwogQ0ZMQUdTOj0JJHtDRkxBR1M6Ti1tcmV0cG9saW5lfQpJbmRl
eDogbGFuZy9nY2M2LWRldmVsL01ha2VmaWxlCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIGxhbmcvZ2NjNi1kZXZl
bC9NYWtlZmlsZQkocmV2aXNpb24gNDgyMTY1KQorKysgbGFuZy9nY2M2LWRldmVsL01ha2VmaWxl
CSh3b3JraW5nIGNvcHkpCkBAIC00MCw2ICs0MCw3IEBACiBTVUZGSVg9CQkke1BPUlRWRVJTSU9O
OkMvKFswLTldKykuKi9cMS99CiBVU0VTPQkJY29tcGlsZXIgY3BlIGdtYWtlIGljb252IGxpYnRv
b2wgbWFrZWluZm8gcGVybDUgdGFyOnh6CiBVU0VfQklOVVRJTFM9CXllcworQklOQVJZX0FMSUFT
PQlzdHJpcD0ke0xPQ0FMQkFTRX0vYmluL3N0cmlwCiBVU0VfUEVSTDU9CWJ1aWxkCiBTU1BfVU5T
QUZFPQl5ZXMKIApJbmRleDogbGFuZy9nY2M3L01ha2VmaWxlCj09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIGxhbmcv
Z2NjNy9NYWtlZmlsZQkocmV2aXNpb24gNDgyMTY1KQorKysgbGFuZy9nY2M3L01ha2VmaWxlCSh3
b3JraW5nIGNvcHkpCkBAIC0zNCw2ICszNCw3IEBACiBTVUZGSVg9CQkke1BPUlRWRVJTSU9OOkMv
KFswLTldKykuKi9cMS99CiBVU0VTPQkJY29tcGlsZXIgY3BlIGdtYWtlIGljb252IGxpYnRvb2wg
bWFrZWluZm8gcGVybDUgdGFyOnh6CiBVU0VfQklOVVRJTFM9CXllcworQklOQVJZX0FMSUFTPQlz
dHJpcD0ke0xPQ0FMQkFTRX0vYmluL3N0cmlwCiBVU0VfUEVSTDU9CWJ1aWxkCiBTU1BfVU5TQUZF
PQl5ZXMKIENGTEFHUzo9CSR7Q0ZMQUdTOk4tbXJldHBvbGluZX0KSW5kZXg6IGxhbmcvZ2NjNy1k
ZXZlbC9NYWtlZmlsZQo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBsYW5nL2djYzctZGV2ZWwvTWFrZWZpbGUJKHJl
dmlzaW9uIDQ4MjE2NSkKKysrIGxhbmcvZ2NjNy1kZXZlbC9NYWtlZmlsZQkod29ya2luZyBjb3B5
KQpAQCAtNDAsNiArNDAsNyBAQAogU1VGRklYPQkJJHtQT1JUVkVSU0lPTjpDLyhbMC05XSspLiov
XDEvfQogVVNFUz0JCWNvbXBpbGVyIGNwZSBnbWFrZSBpY29udiBsaWJ0b29sIG1ha2VpbmZvIHBl
cmw1IHRhcjp4egogVVNFX0JJTlVUSUxTPQl5ZXMKK0JJTkFSWV9BTElBUz0Jc3RyaXA9JHtMT0NB
TEJBU0V9L2Jpbi9zdHJpcAogVVNFX1BFUkw1PQlidWlsZAogU1NQX1VOU0FGRT0JeWVzCiAKSW5k
ZXg6IGxhbmcvZ2NjOC9NYWtlZmlsZQo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBsYW5nL2djYzgvTWFrZWZpbGUJ
KHJldmlzaW9uIDQ4MjE2NSkKKysrIGxhbmcvZ2NjOC9NYWtlZmlsZQkod29ya2luZyBjb3B5KQpA
QCAtMzQsNiArMzQsNyBAQAogU1VGRklYPQkJJHtQT1JUVkVSU0lPTjpDLyhbMC05XSspLiovXDEv
fQogVVNFUz0JCWNvbXBpbGVyIGNwZSBnbWFrZSBpY29udiBsaWJ0b29sIG1ha2VpbmZvIHBlcmw1
IHRhcjp4egogVVNFX0JJTlVUSUxTPQl5ZXMKK0JJTkFSWV9BTElBUz0Jc3RyaXA9JHtMT0NBTEJB
U0V9L2Jpbi9zdHJpcAogVVNFX1BFUkw1PQlidWlsZAogU1NQX1VOU0FGRT0JeWVzCiBDRkxBR1M6
PQkke0NGTEFHUzpOLW1yZXRwb2xpbmV9CkluZGV4OiBsYW5nL2djYzgtZGV2ZWwvTWFrZWZpbGUK
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PQotLS0gbGFuZy9nY2M4LWRldmVsL01ha2VmaWxlCShyZXZpc2lvbiA0ODIxNjUp
CisrKyBsYW5nL2djYzgtZGV2ZWwvTWFrZWZpbGUJKHdvcmtpbmcgY29weSkKQEAgLTQwLDYgKzQw
LDcgQEAKIFNVRkZJWD0JCSR7UE9SVFZFUlNJT046Qy8oWzAtOV0rKS4qL1wxL30KIFVTRVM9CQlj
b21waWxlciBjcGUgZ21ha2UgaWNvbnYgbGlidG9vbCBtYWtlaW5mbyBwZXJsNSB0YXI6eHoKIFVT
RV9CSU5VVElMUz0JeWVzCitCSU5BUllfQUxJQVM9CXN0cmlwPSR7TE9DQUxCQVNFfS9iaW4vc3Ry
aXAKIFVTRV9QRVJMNT0JYnVpbGQKIFNTUF9VTlNBRkU9CXllcwogCkluZGV4OiBsYW5nL2djYzkt
ZGV2ZWwvTWFrZWZpbGUKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gbGFuZy9nY2M5LWRldmVsL01ha2VmaWxlCShy
ZXZpc2lvbiA0ODIxNjUpCisrKyBsYW5nL2djYzktZGV2ZWwvTWFrZWZpbGUJKHdvcmtpbmcgY29w
eSkKQEAgLTM4LDYgKzM4LDcgQEAKIFNVRkZJWD0JCSR7UE9SVFZFUlNJT046Qy8oWzAtOV0rKS4q
L1wxL30KIFVTRVM9CQljb21waWxlciBjcGUgZ21ha2UgaWNvbnYgbGlidG9vbCBtYWtlaW5mbyBw
ZXJsNSB0YXI6eHoKIFVTRV9CSU5VVElMUz0JeWVzCitCSU5BUllfQUxJQVM9CXN0cmlwPSR7TE9D
QUxCQVNFfS9iaW4vc3RyaXAKIFVTRV9QRVJMNT0JYnVpbGQKIFNTUF9VTlNBRkU9CXllcwogCg==
--0000000000001b5a93057851fb83--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAALwa8=rUZh=VaQL0Ln6TsrfaK7maAhdG88AD1ZyDc-UpDMxSQ>