Date: Sat, 18 Nov 2006 20:59:51 +0000 (UTC) From: Konstantin Belousov <kib@FreeBSD.org> To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org Subject: cvs commit: src/sys/security/audit audit_syscalls.c Message-ID: <200611182059.kAIKxpBG080540@repoman.freebsd.org>
next in thread | raw e-mail | index | archive | help
kib 2006-11-18 20:59:50 UTC
FreeBSD src repository
Modified files: (Branch: RELENG_6)
sys/security/audit audit_syscalls.c
Log:
On RELENG_6, vn_open() will drop Giant aquired for calls into
non-MP-safe filesystem if fdx == -1, assuming the in-kernel callers are
not MP-safe. On HEAD, vn_open() after rev. 1.240 of sys/kern/vfs_vnops.c
would keep the Giant locked when the MPSAFE flag is given.
The difference in the API caused the auditctl() syscall code to try to
unlock non-locked Giant for non-MP-safe filesystems, for instance, UFS
when QUOTA is compiled in.
This is direct commit to RELENG_6 to accomodate for RELENG_6' vn_open().
Reported by: Steve Wills (steve at stevenwills com)
Reviewed by: rwatson
Approved by: re (bmah)
X-MFC to RELENG_6_2 after: 3 days
Revision Changes Path
1.1.2.5 +2 -2 src/sys/security/audit/audit_syscalls.c
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200611182059.kAIKxpBG080540>