Date: Wed, 29 Oct 2025 17:53:33 GMT From: Konrad Witaszczyk <def@FreeBSD.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org Subject: git: 2acdec9e4d91 - main - dtrace/arm64: properly traverse the symbol table Message-ID: <202510291753.59THrXsD094754@gitrepo.freebsd.org>
index | next in thread | raw e-mail
The branch main has been updated by def: URL: https://cgit.FreeBSD.org/src/commit/?id=2acdec9e4d915ec61d0ca45b408f9beb7aa4b772 commit 2acdec9e4d915ec61d0ca45b408f9beb7aa4b772 Author: Konrad Witaszczyk <def@FreeBSD.org> AuthorDate: 2025-10-28 16:09:24 +0000 Commit: Konrad Witaszczyk <def@FreeBSD.org> CommitDate: 2025-10-29 17:52:42 +0000 dtrace/arm64: properly traverse the symbol table LINKER_EACH_FUNCTION_NAMEVAL() stops processing the symbol table if a callback function returns a non-zero value. The fbt_provide_module_function() callback should not return 1 when ignoring symbols. Instead, always return 0, as in dtrace/x86. Fixes: 30b68ecda84e ("Changes that improve DTrace FBT reliability on freebsd/arm64:") Reviewed by: markj, oshogbo Approved by: oshogbo (mentor) Obtained from: CheriBSD Differential Revision: https://reviews.freebsd.org/D53399 --- sys/cddl/dev/fbt/aarch64/fbt_isa.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sys/cddl/dev/fbt/aarch64/fbt_isa.c b/sys/cddl/dev/fbt/aarch64/fbt_isa.c index ffe2f37a6d16..6c789530442d 100644 --- a/sys/cddl/dev/fbt/aarch64/fbt_isa.c +++ b/sys/cddl/dev/fbt/aarch64/fbt_isa.c @@ -104,7 +104,7 @@ fbt_provide_module_function(linker_file_t lf, int symindx, */ if (strcmp(name, "handle_el1h_sync") == 0 || strcmp(name, "do_el1h_sync") == 0) - return (1); + return (0); instr = (uint32_t *)(symval->value); limit = (uint32_t *)(symval->value + symval->size);home | help
Want to link to this message? Use this
URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?202510291753.59THrXsD094754>