Date: Sat, 14 Nov 2020 15:53:55 -0500 From: Shawn Webb <shawn.webb@hardenedbsd.org> To: Mateusz Guzik <mjguzik@gmail.com> Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r367692 - head/sys/sys Message-ID: <20201114205355.j2ejnhouipjr6yhk@mutt-hbsd> In-Reply-To: <CAGudoHGSxyVZAF%2BFF=LFR0pDkSbYd78Vo1xRYQnKo_hUPVhxgA@mail.gmail.com> References: <202011141920.0AEJKbpO050396@repo.freebsd.org> <20201114205036.tnxvwarsddmu4shz@mutt-hbsd> <CAGudoHGSxyVZAF%2BFF=LFR0pDkSbYd78Vo1xRYQnKo_hUPVhxgA@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
--hlgimau7p42bbikt Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Are there any kernel modules (in base, in ports, or out-of-both-trees) that access struct ucred? On Sat, Nov 14, 2020 at 09:51:47PM +0100, Mateusz Guzik wrote: > I don't think so, it does not change any APIs >=20 > On 11/14/20, Shawn Webb <shawn.webb@hardenedbsd.org> wrote: > > On Sat, Nov 14, 2020 at 07:20:37PM +0000, Mateusz Guzik wrote: > >> Author: mjg > >> Date: Sat Nov 14 19:20:37 2020 > >> New Revision: 367692 > >> URL: https://svnweb.freebsd.org/changeset/base/367692 > >> > >> Log: > >> cred: reorder cr_audit to be closer to the lock > >> > >> This makes cr_uid avoid sharing. > >> > >> Modified: > >> head/sys/sys/ucred.h > >> > >> Modified: head/sys/sys/ucred.h > >> =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D > >> --- head/sys/sys/ucred.h Sat Nov 14 19:19:27 2020 (r367691) > >> +++ head/sys/sys/ucred.h Sat Nov 14 19:20:37 2020 (r367692) > >> @@ -63,6 +63,7 @@ struct ucred { > >> struct mtx cr_mtx; > >> u_int cr_ref; /* (c) reference count */ > >> u_int cr_users; /* (c) proc + thread using this cred */ > >> + struct auditinfo_addr cr_audit; /* Audit properties. */ > >> #define cr_startcopy cr_uid > >> uid_t cr_uid; /* effective user id */ > >> uid_t cr_ruid; /* real user id */ > >> @@ -78,7 +79,6 @@ struct ucred { > >> void *cr_pspare2[2]; /* general use 2 */ > >> #define cr_endcopy cr_label > >> struct label *cr_label; /* MAC label */ > >> - struct auditinfo_addr cr_audit; /* Audit properties. */ > >> gid_t *cr_groups; /* groups */ > >> int cr_agroups; /* Available groups */ > >> gid_t cr_smallgroups[XU_NGROUPS]; /* storage for small groups */ > > > > Hey Mateusz, > > > > Since this changes KBI, does __FreeBSD_version need bumping? > > > > Thanks, > > > > -- > > Shawn Webb > > Cofounder / Security Engineer > > HardenedBSD > > > > GPG Key ID: 0xFF2E67A277F8E1FA > > GPG Key Fingerprint: D206 BB45 15E0 9C49 0CF9 3633 C85B 0AF8 AB23 0FB2 > > https://git-01.md.hardenedbsd.org/HardenedBSD/pubkeys/src/branch/master= /Shawn_Webb/03A4CBEBB82EA5A67D9F3853FF2E67A277F8E1FA.pub.asc > > >=20 >=20 > --=20 > Mateusz Guzik <mjguzik gmail.com> --=20 Shawn Webb Cofounder / Security Engineer HardenedBSD GPG Key ID: 0xFF2E67A277F8E1FA GPG Key Fingerprint: D206 BB45 15E0 9C49 0CF9 3633 C85B 0AF8 AB23 0FB2 https://git-01.md.hardenedbsd.org/HardenedBSD/pubkeys/src/branch/master/Sha= wn_Webb/03A4CBEBB82EA5A67D9F3853FF2E67A277F8E1FA.pub.asc --hlgimau7p42bbikt Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCAAdFiEEA6TL67gupaZ9nzhT/y5nonf44foFAl+wQ+MACgkQ/y5nonf4 4foLOA//XUBGhKNLIdGAL8WAKKSqXimkpbehN+hL9yh5GbERMvnSiCBiumb+nFvL GrAw5Fmea4soSW4eZcZc4goRy9md5vy0e6BnMEt6MjM534RlWNDDDiwmN3gMlmFh Gw8MveFNqXwDaebeV5b3PCPCqKeMGV6aRjg8Vz4TGPBP+ClcN/FW99MAEsniERGV pJ3u1aGtoOPBgB5PaRLrUqylAFU8ol5aLi+rCk2buAZlKvjxHTMFS2C2Fskq+KeD LsHJmX9cWjktWCXjK8rhpbUGAbQxcviYy7627pNIzh1gXO6sM60Tw7wNDZpAgYF7 cZxgt1om69dLWjZCu9RULhFeNqkEAK6GNNI7VvVt3WMWfvjy3wOXTegmHXnwCfx1 eESkqJ+ufH86ZPs2tWPpso8mpf3tgN0b1uWa5p3JnTH4JWg19X8NNeSJQsh56SYD 986hFsNdrBdmDonwK0oDYbJUMShS2yUtfWNTuq/NBcjHiUPAObLyeNlC0LbD64YR vcfJBtpbsf26B2vqyBpqxqX6xJ2GFVItRWFSwRAGGoMKSIe1vkn8YbYyTKOvsPI4 ygYpfyDe9K5CXwkmyXbK8DivsmYiPDYzckSipekG3l58ikAs+aZTUtVpR6/NYRUU UlQVs4NmQNXeS/72GO9o8BNcZHQ5UkUKUyyo82m2XK81aA7691s= =pcKy -----END PGP SIGNATURE----- --hlgimau7p42bbikt--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20201114205355.j2ejnhouipjr6yhk>