Date: Thu, 25 Aug 2016 09:24:15 -0700 From: Bryan Drewery <bdrewery@FreeBSD.org> To: Guido Falsi <madpilot@FreeBSD.org>, Ed Schouten <ed@nuxi.nl> Cc: svn-src-head@freebsd.org, jilles@freebsd.org, svn-src-all@freebsd.org, src-committers <src-committers@freebsd.org>, Ed Schouten <ed@freebsd.org> Subject: Re: svn commit: r303988 - head/lib/libc/gen Message-ID: <b1e9b368-2900-269e-c281-7de14cecfcf6@FreeBSD.org> In-Reply-To: <9303f35a-7941-3d14-4068-563d6af5b7ee@FreeBSD.org> References: <201608120703.u7C73whf007189@repo.freebsd.org> <d23b295a-1902-193c-dee6-ba49ebd77280@FreeBSD.org> <9ae1c2eb-02ad-b8fe-6aff-7e17e955607a@FreeBSD.org> <CABh_MKkxD3OTF7VO9Rq_eZyqHPN%2BxVws3q3dsH2R3DfZ343kFw@mail.gmail.com> <2632f5f8-d765-3df7-74d7-da878eb4b7a8@FreeBSD.org> <CABh_MKm_YQ3bJD19Cz1vBCGr=YxuzctXV6F1iqMASkSx-PsVMw@mail.gmail.com> <2e308383-bfbb-cccd-cfc2-eba63d275f5e@FreeBSD.org> <f4d148a5-2746-b88a-dd84-28c88de91bde@FreeBSD.org> <9303f35a-7941-3d14-4068-563d6af5b7ee@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --gCKvi3GUwubIU0mG2vMbE0MTjF7K8v79J Content-Type: multipart/mixed; boundary="KGDneuT95b2IHfDE3utxjT7Jf0O5D83nK" From: Bryan Drewery <bdrewery@FreeBSD.org> To: Guido Falsi <madpilot@FreeBSD.org>, Ed Schouten <ed@nuxi.nl> Cc: svn-src-head@freebsd.org, jilles@freebsd.org, svn-src-all@freebsd.org, src-committers <src-committers@freebsd.org>, Ed Schouten <ed@freebsd.org> Message-ID: <b1e9b368-2900-269e-c281-7de14cecfcf6@FreeBSD.org> Subject: Re: svn commit: r303988 - head/lib/libc/gen References: <201608120703.u7C73whf007189@repo.freebsd.org> <d23b295a-1902-193c-dee6-ba49ebd77280@FreeBSD.org> <9ae1c2eb-02ad-b8fe-6aff-7e17e955607a@FreeBSD.org> <CABh_MKkxD3OTF7VO9Rq_eZyqHPN+xVws3q3dsH2R3DfZ343kFw@mail.gmail.com> <2632f5f8-d765-3df7-74d7-da878eb4b7a8@FreeBSD.org> <CABh_MKm_YQ3bJD19Cz1vBCGr=YxuzctXV6F1iqMASkSx-PsVMw@mail.gmail.com> <2e308383-bfbb-cccd-cfc2-eba63d275f5e@FreeBSD.org> <f4d148a5-2746-b88a-dd84-28c88de91bde@FreeBSD.org> <9303f35a-7941-3d14-4068-563d6af5b7ee@FreeBSD.org> In-Reply-To: <9303f35a-7941-3d14-4068-563d6af5b7ee@FreeBSD.org> --KGDneuT95b2IHfDE3utxjT7Jf0O5D83nK Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 8/25/16 9:17 AM, Guido Falsi wrote: > On 08/25/16 18:05, Bryan Drewery wrote: >> On 8/25/16 1:27 AM, Guido Falsi wrote: >>> On 08/24/16 21:49, Ed Schouten wrote: >>>> 2016-08-24 20:30 GMT+02:00 Bryan Drewery <bdrewery@freebsd.org>: >>>>> That would only fix stable/11, stable/10, stable/9, releng/11.0. >>>>> >>>>> It won't fix releng/10.3, releng/10.2, releng/10.1, releng/9.3, etc= =2E.. >>>>> without an EN. >>>>> >>>>> It won't fix stable/11 - 1, stable/10 - 1, etc. >>>>> >>>>> It will never fix releng/8.4 (unsupported releases) since so@ won't= EN >>>>> to those. People do sometimes need to build these older releases s= till. >>>>> >>>>> It creates a line in the sand where we can never build checkouts ol= der >>>>> than where the fix was at. So I don't think it is the appropriate = fix. >>>> >>>> Good point! >>>> >>>> Just for the record: Bryan and I just discussed this matter in more >>>> detail on IRC. We came up with a workaround that should be pretty >>>> good. >>>> >>>> Attached is a patch for <libgen.h> that adds some extra logic, so th= at >>>> any calls to basename() and dirname() will expand to calls to >>>> __old_basename() and __old_dirname(). Using __sym_compat(), these wi= ll >>>> cause the compiler to generate calls to basename@FBSD_1.0 and >>>> dirname@FBSD_1.0. >>>> >>>> According to Bryan, this fixes the problems he was experiencing. >>>> >>> >>> I just tried using the attached patch to build a nanobsd image, host = is >>> amd64 head at r304773 with this patch applied, target is i386 >>> releng/11.0 at r304729. >>> >> >> What did you apply the patch to? >> >> You need to apply to the source tree, then do a buildworld/installworl= d >> for the host, then try nanobsd. >=20 > I did apply it to the source tree of the host machine, and did not appl= y > it to the nanobsd sources. >=20 > The error message is very different from the previous one and involves > symbol versioning. >=20 >> >>> I've got it failing early during build: >>> >>> --- _bootstrap-tools-usr.bin/xinstall --- >>> xinstall.o: In function `install': >>> /usr/local/nanobsd/rr-trunk/src/usr.bin/xinstall/xinstall.c:(.text+0x= f55): >>> undefined reference to `basename@FBSD_1.0' readelf -a /lib/libc.so.7|grep basename ? >>> cc: error: linker command failed with exit code 1 (use -v to see invo= cation) >>> *** [xinstall] Error code 1 >>> >>> make[3]: stopped in /usr/local/nanobsd/rr-trunk/src/usr.bin/xinstall >>> 1 error >>> >>> make[3]: stopped in /usr/local/nanobsd/rr-trunk/src/usr.bin/xinstall >>> *** [_bootstrap-tools-usr.bin/xinstall] Error code 2 >>> >>> Did I miss some needed procedure? >>> >>> Thanks! >>> >> >> >=20 >=20 --=20 Regards, Bryan Drewery --KGDneuT95b2IHfDE3utxjT7Jf0O5D83nK-- --gCKvi3GUwubIU0mG2vMbE0MTjF7K8v79J Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Comment: GPGTools - https://gpgtools.org iQEcBAEBCgAGBQJXvxuvAAoJEDXXcbtuRpfPU+UIAKpIqBQ4McrxR9uSdN6g0/nE oV+aNF9WobCBcGdTSAkWqJlsDCLnSbfqVbp6dUhFEUZGO6M4Mq0qWmN/aOi/32Gt RLaRQivHUYS4LcPxd9KBAoTsbKw7faOwBMeJ7bvxIWx3BPqA8vErV+GeGy9PxhbT LI3+EYKpE9HMqfBcBpqdAmSWBCR6H3FdelMK2TgHhA1vlRUGrMAw2SLu1gwMVRYL ev0t1mjCHK1AhLAXI9fmDJ9eE95HfZ8iwZof+zc4umF5Ev8/zS2GmKPseUoWsB8X hLXrIK06Vdmiu+7BtobafF+QyMa7ehbaDmB8bYKFcnwfDgWm9h40TKsT4Gx9mOA= =D/1i -----END PGP SIGNATURE----- --gCKvi3GUwubIU0mG2vMbE0MTjF7K8v79J--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?b1e9b368-2900-269e-c281-7de14cecfcf6>