Date: Fri, 14 Dec 2018 13:25:06 -0500 From: Jung-uk Kim <jkim@FreeBSD.org> To: koobs@FreeBSD.org, src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r342057 - head/crypto/openssl/crypto/engine Message-ID: <3f9a0289-4539-368f-0ddd-b9ca9be2ac69@FreeBSD.org> In-Reply-To: <216fb35b-28d1-faaa-d115-1f4a601212f0@FreeBSD.org> References: <201812140106.wBE16Zgr058499@repo.freebsd.org> <216fb35b-28d1-faaa-d115-1f4a601212f0@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --XhGWniLjE0DGInk1VEfa2XZqOHrFDd7TG Content-Type: multipart/mixed; boundary="9UFlAsadM5x6cqJVyckHyAvuhzcdr5230"; protected-headers="v1" From: Jung-uk Kim <jkim@FreeBSD.org> To: koobs@FreeBSD.org, src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Message-ID: <3f9a0289-4539-368f-0ddd-b9ca9be2ac69@FreeBSD.org> Subject: Re: svn commit: r342057 - head/crypto/openssl/crypto/engine References: <201812140106.wBE16Zgr058499@repo.freebsd.org> <216fb35b-28d1-faaa-d115-1f4a601212f0@FreeBSD.org> In-Reply-To: <216fb35b-28d1-faaa-d115-1f4a601212f0@FreeBSD.org> --9UFlAsadM5x6cqJVyckHyAvuhzcdr5230 Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: quoted-printable On 18. 12. 13., Kubilay Kocak wrote: > On 14/12/2018 12:06 pm, Jung-uk Kim wrote: >> Author: jkim >> Date: Fri Dec 14 01:06:34 2018 >> New Revision: 342057 >> URL: https://svnweb.freebsd.org/changeset/base/342057 >> >> Log: >> =C2=A0=C2=A0 Do not complain when /dev/crypto does not exist. >> =C2=A0=C2=A0 =C2=A0=C2=A0 Now the new devcrypto engine is enabled sinc= e r342009, many >> users started >> =C2=A0=C2=A0 seeing "Could not open /dev/crypto: No such file or direc= tory".=C2=A0 >> Disable >> =C2=A0=C2=A0 the annoying error message as it is not very useful anywa= y. >> =C2=A0=C2=A0 =C2=A0=C2=A0 Note the patch was submitted upstream. >> =C2=A0=C2=A0 =C2=A0=C2=A0 https://github.com/openssl/openssl/pull/7896= >> >> Modified: >> =C2=A0=C2=A0 head/crypto/openssl/crypto/engine/eng_devcrypto.c >> >> Modified: head/crypto/openssl/crypto/engine/eng_devcrypto.c >> =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D >> >> --- head/crypto/openssl/crypto/engine/eng_devcrypto.c=C2=A0=C2=A0=C2=A0= Fri Dec 14 >> 00:40:38 2018=C2=A0=C2=A0=C2=A0 (r342056) >> +++ head/crypto/openssl/crypto/engine/eng_devcrypto.c=C2=A0=C2=A0=C2=A0= Fri Dec 14 >> 01:06:34 2018=C2=A0=C2=A0=C2=A0 (r342057) >> @@ -24,6 +24,8 @@ >> =C2=A0 =C2=A0 #include "internal/engine.h" >> =C2=A0 +/* #define ENGINE_DEVCRYPTO_DEBUG */ >> + >> =C2=A0 #ifdef CRYPTO_ALGORITHM_MIN >> =C2=A0 # define CHECK_BSD_STYLE_MACROS >> =C2=A0 #endif >> @@ -615,6 +617,9 @@ void engine_load_devcrypto_int() >> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 ENGINE *e =3D NULL; >> =C2=A0 =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 if ((cfd =3D open("/dev/crypto",= O_RDWR, 0)) < 0) { >> +#ifndef ENGINE_DEVCRYPTO_DEBUG >> +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 if (errno !=3D ENOENT) >> +#endif >> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 fprintf(stderr,= "Could not open /dev/crypto: %s\n", >> strerror(errno)); >> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 return; >> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 } >=20 > How trivially could devcrypto_debug=C2=A0 be modified to be a runtime > configuration (say sysctl) setting? This file came from OpenSSL and we will not implement any FreeBSD-specific code like that. Jung-uk Kim --9UFlAsadM5x6cqJVyckHyAvuhzcdr5230-- --XhGWniLjE0DGInk1VEfa2XZqOHrFDd7TG Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAEBCAAdFiEEl1bqgKaRyqfWXu/CfJ+WJvzb8UYFAlwT9YoACgkQfJ+WJvzb 8UY/fAf/dTgaLXh5IFr1c2gsrDikLb141+D76BZRXtOMMJ9JyYc6gLhasQmOD/0H pdIFAIuNRlAAREzp9qT2b9MVglk9huvUNZ8a/vHOpQ2+JQKrnb5pjKJIn0u3ZQze nKQKN0vUKv/r1ZR4iH7I/36WRUDyz2LtfTct96CZU3O99GQZNsutikjqaufPKJ76 lb0P/bZGOgZuNMGuw4g5vThZfKJw7oRb0qKuu0xzEgrGSmk8cC99PMU3tpojw2Je iKQv0zZwD+nYKerPkAum4zl8oUsOZACAQBEKrQSEVuDo00NP7SNOPB9rVK4PbyS6 HVQct6geW/lqJ9o/DU5fUXotHkZQrA== =Ponw -----END PGP SIGNATURE----- --XhGWniLjE0DGInk1VEfa2XZqOHrFDd7TG--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?3f9a0289-4539-368f-0ddd-b9ca9be2ac69>