Skip site navigation (1)Skip section navigation (2)
Date:      Tue, 8 Oct 2019 20:22:05 +0000 (UTC)
From:      John Baldwin <jhb@FreeBSD.org>
To:        src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org
Subject:   svn commit: r353323 - head/sys/dev/cxgbe/crypto
Message-ID:  <201910082022.x98KM5WK046091@repo.freebsd.org>

next in thread | raw e-mail | index | archive | help
Author: jhb
Date: Tue Oct  8 20:22:05 2019
New Revision: 353323
URL: https://svnweb.freebsd.org/changeset/base/353323

Log:
  Set the FID field in lookaside crypto requests to the rx queue ID.
  
  The PCI block in the adapter requires this field to be set to a valid
  queue ID.  It is not clear why it did not fail on all machines, but
  the effect was that crypto operations reading input data via DMA
  failed with an internal PCI read error on machines with 128G or more
  of RAM.
  
  Reported by:	gallatin
  Reviewed by:	np
  MFC after:	3 days
  Sponsored by:	Chelsio Communications

Modified:
  head/sys/dev/cxgbe/crypto/t4_crypto.c

Modified: head/sys/dev/cxgbe/crypto/t4_crypto.c
==============================================================================
--- head/sys/dev/cxgbe/crypto/t4_crypto.c	Tue Oct  8 20:14:33 2019	(r353322)
+++ head/sys/dev/cxgbe/crypto/t4_crypto.c	Tue Oct  8 20:22:05 2019	(r353323)
@@ -419,7 +419,7 @@ ccr_populate_wreq(struct ccr_softc *sc, struct chcr_wr
 	crwr->ulptx.cmd_dest = htobe32(V_ULPTX_CMD(ULP_TX_PKT) |
 	    V_ULP_TXPKT_DATAMODIFY(0) |
 	    V_ULP_TXPKT_CHANNELID(sc->tx_channel_id) | V_ULP_TXPKT_DEST(0) |
-	    V_ULP_TXPKT_FID(0) | V_ULP_TXPKT_RO(1));
+	    V_ULP_TXPKT_FID(sc->rxq->iq.abs_id) | V_ULP_TXPKT_RO(1));
 	crwr->ulptx.len = htobe32(
 	    ((wr_len - sizeof(struct fw_crypto_lookaside_wr)) / 16));
 



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201910082022.x98KM5WK046091>