Date: Tue, 23 Jun 2020 07:07:01 +0000 From: "aleksandr.fedorov_itglobal.com (Aleksandr Fedorov)" <phabric-noreply@FreeBSD.org> To: Phabricator <phabric-noreply@FreeBSD.org> Cc: freebsd-net@freebsd.org Subject: [Differential] D24937: Add sysctl net.iflib.tx_update_freq to set transmit descriptor update frequency Message-ID: <f24621a3a1421711a9780786719c4dd3@localhost.localdomain> In-Reply-To: <differential-rev-PHID-DREV-sjntqne4ry32ikjhkxqq-req@reviews.freebsd.org> References: <differential-rev-PHID-DREV-sjntqne4ry32ikjhkxqq-req@reviews.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
aleksandr.fedorov_itglobal.com added inline comments. INLINE COMMENTS > iflib.c:2916 > > #define TXD_NOTIFY_COUNT(txq) (((txq)->ift_size / (txq)->ift_update_freq)-1) > static inline qidx_t I am worried that if the user sets the value to 1, then this will lead to division by zero and to kernel panic. I think additional checks are needed. REPOSITORY rS FreeBSD src repository CHANGES SINCE LAST ACTION https://reviews.freebsd.org/D24937/new/ REVISION DETAIL https://reviews.freebsd.org/D24937 EMAIL PREFERENCES https://reviews.freebsd.org/settings/panel/emailpreferences/ To: neel_neelc.org, shurd, #iflib Cc: aleksandr.fedorov_itglobal.com, koobs, imp, ae, melifaro, #contributor_reviews_base, freebsd-net-list, mmacy, kpraveen.lkml_gmail.com, marcnarc_gmail.com, simonvella_gmail.com, novice_techie.com, tommi.pernila_iki.fi, krzysztof.galazka_intel.com
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?f24621a3a1421711a9780786719c4dd3>