Skip site navigation (1)Skip section navigation (2)
Date:      Sat, 16 Jan 2016 02:02:51 +0000 (UTC)
From:      Garrett Cooper <ngie@FreeBSD.org>
To:        src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org
Subject:   svn commit: r294125 - in head/tools/regression/sockets: rtsocket unix_socket
Message-ID:  <201601160202.u0G22paX063699@repo.freebsd.org>

next in thread | raw e-mail | index | archive | help
Author: ngie
Date: Sat Jan 16 02:02:50 2016
New Revision: 294125
URL: https://svnweb.freebsd.org/changeset/base/294125

Log:
  Test for EPROTOTYPE not EPROTONOSUPPORT
  
  - `SOCK_RAW` is the implied supported type parameter for socket(2) per route(4)
  - localsw in `sys/kern/uipc_usrreq.c` doesn't have an entry for `SOCK_RAW`, so
    the prototype is invalid (this isn't explicitly documented anywhere I could
    find)
  
  MFC after: 1 week
  Sponsored by: EMC / Isilon Storage Division

Modified:
  head/tools/regression/sockets/rtsocket/rtsocket.c
  head/tools/regression/sockets/unix_socket/unix_socket.c
Directory Properties:
  head/   (props changed)

Modified: head/tools/regression/sockets/rtsocket/rtsocket.c
==============================================================================
--- head/tools/regression/sockets/rtsocket/rtsocket.c	Sat Jan 16 01:40:46 2016	(r294124)
+++ head/tools/regression/sockets/rtsocket/rtsocket.c	Sat Jan 16 02:02:50 2016	(r294125)
@@ -52,7 +52,7 @@ main(void)
 		    sock);
 	}
 
-	if (errno != EPROTONOSUPPORT)
+	if (errno != EPROTOTYPE)
 		err(-1, "socket(PF_ROUTE, SOCK_STREAM, 0)");
 
 	sock = socket(PF_ROUTE, SOCK_DGRAM, 0);
@@ -62,7 +62,7 @@ main(void)
 		    sock);
 	}
 
-	if (errno != EPROTONOSUPPORT)
+	if (errno != EPROTOTYPE)
 		err(-1, "socket(PF_ROUTE, SOCK_DGRAM, 0)");
 
 	sock = socket(PF_ROUTE, SOCK_RAW, 0);
@@ -77,7 +77,7 @@ main(void)
 		    "socketpair(PF_ROUTE, SOCK_STREAM, 0, socks) success");
 	}
 
-	if (errno != EPROTONOSUPPORT)
+	if (errno != EPROTOTYPE)
 		err(-1, "socketpair(PF_ROUTE, SOCK_STREAM, 0, socks)");
 
 	if (socketpair(PF_ROUTE, SOCK_DGRAM, 0, socks) == 0) {
@@ -87,7 +87,7 @@ main(void)
 		    "socketpair(PF_ROUTE, SOCK_DGRAM, 0, socks) success");
 	}
 
-	if (errno != EPROTONOSUPPORT)
+	if (errno != EPROTOTYPE)
 		err(-1, "socketpair(PF_ROUTE, SOCK_DGRAM, 0, socks)");
 
 	if (socketpair(PF_ROUTE, SOCK_RAW, 0, socks) == 0) {

Modified: head/tools/regression/sockets/unix_socket/unix_socket.c
==============================================================================
--- head/tools/regression/sockets/unix_socket/unix_socket.c	Sat Jan 16 01:40:46 2016	(r294124)
+++ head/tools/regression/sockets/unix_socket/unix_socket.c	Sat Jan 16 02:02:50 2016	(r294125)
@@ -59,7 +59,7 @@ main(void)
 		close(sock);
 		errx(-1, "socket(PF_LOCAL, SOCK_RAW, 0) returned %d", sock);
 	}
-	if (errno != EPROTONOSUPPORT)
+	if (errno != EPROTOTYPE)
 		err(-1, "socket(PF_LOCAL, SOCK_RAW, 0)");
 
 	if (socketpair(PF_LOCAL, SOCK_STREAM, 0, socks) < 0)



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201601160202.u0G22paX063699>