Date: Wed, 10 Feb 2010 12:08:32 -0500 From: jhell <jhell@DataIX.net> To: Balaji G <balajig81@gmail.com> Cc: freebsd-net@freebsd.org, "Li, Qing" <qing.li@bluecoat.com>, Qing Li <qingli@freebsd.org> Subject: Re: [PATCH] net:: ECMP Phase 1 Fixes for FreeBSD 7.2 Message-ID: <alpine.BSF.2.00.1002101203130.96508@pragry.qngnvk.ybpny> In-Reply-To: <6dd1343e1002092253j5b111d42m7c354ca372241dde@mail.gmail.com> References: <6dd1343e1002080739m38f4deffr604c71e5036389a4@mail.gmail.com> <alpine.BSF.2.00.1002100136230.19249@pragry.qngnvk.ybpny> <6dd1343e1002092253j5b111d42m7c354ca372241dde@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On Wed, 10 Feb 2010 01:53, balajig81@ wrote: > Hi Jhell > >> Delete keys get in the way some times ;) > > I am sorry i didn't understand your comment. Is it wrong or should i change > something, please let me know so that i could create an other patch . > Please see below. > PS: I had also sent an email to the list to take up some items mentioned in > the Wiki Page under the networking section. It would be nice if by any > chance you know who's the contact person :). for those activities. > I do not remember who the contact person is at the moment but it would be safe to say he/she is probably watching mailing list. > Thanks for your feedback and time :) > > Thanks, > Cheers, > - Balaji > > > On Wed, Feb 10, 2010 at 12:11 PM, jhell <jhell@dataix.net> wrote: > >> >> On Mon, 8 Feb 2010 10:39, balajig81@ wrote: >> >>> Hi Everybody >>> >>> Please find attached the patch files which contains the backported code >>> for >>> ECMP for FreeBSD 7.2. I have back ported the code from 8.0. I have done >>> some >>> basic testing with these patches rolled in. These are the phase 1 fixes >>> and >>> i would continue to work on this and back port few other stuff too. It >>> would >>> be great if someone could roll in this to 7.2, test it and give me their >>> valuable feedback. >>> >>> This is my first Patch for FreeBSD community and i am really excited about >>> this and look forward to it. >>> >>> Thanks for your time. >>> >>> Cheers, >>> - Balaji >>> >>> >> In ecmp_patch1 you have, >> >> @@ -320,8 +320,9 @@ >> #endif >> >> extern int in6_inithead(void **head, int off); >> -extern int in_inithead(void **head, int off); >> +extern int in_inthead(void **head, int off); >> Problem is with the above two lines explicitly "in_inthead" should be "in_inithead" but it looked to me like it was a mistake and that you did not mean to delete the "i" which is why I said the following. >> ?? >> >> Delete keys get in the way some times ;) >> >> -- >> >> jhell >> >> > Best regards. -- jhell
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?alpine.BSF.2.00.1002101203130.96508>