Date: Sun, 8 Aug 2010 15:07:09 +0200 From: Pawel Jakub Dawidek <pjd@FreeBSD.org> To: Marius =?iso-8859-1?Q?N=FCnnerich?= <marius@nuenneri.ch> Cc: freebsd-hackers@freebsd.org, freebsd-current@freebsd.org, Ivan Voras <ivoras@freebsd.org>, freebsd-geom@freebsd.org Subject: Re: glabel "force sectorsize" patch Message-ID: <20100808130709.GD2037@garage.freebsd.pl> In-Reply-To: <AANLkTinx%2B8wTRMiyQ1yPPJXkYSTEBa=2HYJoWM_nrhq-@mail.gmail.com> References: <AANLkTinBA04YM=uwNJ4sog2KMACUQfpJm7f-CjnRB39x@mail.gmail.com> <20100808103055.GA2037@garage.freebsd.pl> <i3m6c9$7ch$1@dough.gmane.org> <AANLkTinx%2B8wTRMiyQ1yPPJXkYSTEBa=2HYJoWM_nrhq-@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
--wLAMOaPNJ0fu1fTG Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sun, Aug 08, 2010 at 02:57:20PM +0200, Marius N=FCnnerich wrote: > On Sun, Aug 8, 2010 at 14:02, Ivan Voras <ivoras@freebsd.org> wrote: > > I'd like to hear comments from the wider audience. In respect with your > > comment, I will compromise: as 4k sector drives have become available > > over the counter more than 6 months ago and so far I think this is the > > first effort to give some support for them, I will commit this patch > > before 9.0 code freeze only if no other support gets developed. >=20 > I do not like this at all. Even if it's just for the KISS and POLA > principles. A geom should do one thing and do it right imo. > Why not write a new geom class that does what you want? New GEOM class only for sectorsize conversion that can operate on metadata will be useful, not only to solve this particular problem. Although keep in mind that if at some point disks will be detected and presented as 4kB providers to the GEOM, this class won't be able to find its metadata anymore (as it was stored in the last 512 bytes, not in the last 4 kilobytes). --=20 Pawel Jakub Dawidek http://www.wheelsystems.com pjd@FreeBSD.org http://www.FreeBSD.org FreeBSD committer Am I Evil? Yes, I Am! --wLAMOaPNJ0fu1fTG Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.14 (FreeBSD) iEYEARECAAYFAkxeq/0ACgkQForvXbEpPzSslACffbs/r5gFexV0pRgsaN76YDej ONEAoIpXoEgrLqpWXs7Vk4kryYTyvWUu =mN1A -----END PGP SIGNATURE----- --wLAMOaPNJ0fu1fTG--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20100808130709.GD2037>