Date: Mon, 03 Nov 2003 10:02:33 +0100 From: des@des.no (Dag-Erling =?iso-8859-1?q?Sm=F8rgrav?=) To: Soren Schmidt <sos@spider.deepcore.dk> Cc: Harald Schmalzbauer <h@schmalzbauer.de> Subject: Re: hw.ata.atapi_dma vanished Message-ID: <xzpn0bdeseu.fsf@dwp.des.no> In-Reply-To: <200311030810.hA38A2cq062907@spider.deepcore.dk> (Soren Schmidt's message of "Mon, 3 Nov 2003 09:10:02 %2B0100 (CET)") References: <200311030810.hA38A2cq062907@spider.deepcore.dk>
next in thread | previous in thread | raw e-mail | index | archive | help
--=-=-=
Content-Type: text/plain; charset=iso-8859-1
Content-Transfer-Encoding: quoted-printable
Soren Schmidt <sos@spider.deepcore.dk> writes:
> It diapeared some time ago, but setting it in loader.conf still works
> you just cannot see it. Its on my TODO list, but real bugs has priority
> over this minor nit...
Then you won't mind if I commit the attached patch?
DES
--=20
Dag-Erling Sm=F8rgrav - des@des.no
--=-=-=
Content-Type: text/x-patch
Content-Disposition: attachment; filename=ata.diff
Index: ata-all.c
===================================================================
RCS file: /home/ncvs/src/sys/dev/ata/ata-all.c,v
retrieving revision 1.195
diff -u -r1.195 ata-all.c
--- ata-all.c 12 Oct 2003 12:37:11 -0000 1.195
+++ ata-all.c 3 Nov 2003 09:01:30 -0000
@@ -76,8 +76,14 @@
/* sysctl vars */
SYSCTL_NODE(_hw, OID_AUTO, ata, CTLFLAG_RD, 0, "ATA driver parameters");
TUNABLE_INT("hw.ata.ata_dma", &ata_dma);
+SYSCTL_INT(_hw_ata, OID_AUTO, ata_dma, CTLFLAG_RDTUN, &ata_dma, 0,
+ "ATA disk DMA mode control");
TUNABLE_INT("hw.ata.wc", &ata_wc);
+SYSCTL_INT(_hw_ata, OID_AUTO, wc, CTLFLAG_RDTUN, &ata_wc, 0,
+ "ATA disk write caching");
TUNABLE_INT("hw.ata.atapi_dma", &atapi_dma);
+SYSCTL_INT(_hw_ata, OID_AUTO, atapi_dma, CTLFLAG_RDTUN, &atapi_dma, 0,
+ "ATAPI device DMA mode control");
int ata_dma = 1;
int ata_wc = 1;
int atapi_dma = 0;
Index: ata-disk.c
===================================================================
RCS file: /home/ncvs/src/sys/dev/ata/ata-disk.c,v
retrieving revision 1.161
diff -u -r1.161 ata-disk.c
--- ata-disk.c 21 Oct 2003 18:28:34 -0000 1.161
+++ ata-disk.c 3 Nov 2003 09:01:09 -0000
@@ -67,13 +67,6 @@
static MALLOC_DEFINE(M_AD, "AD driver", "ATA disk driver");
static u_int32_t adp_lun_map = 0;
-/* sysctl vars */
-SYSCTL_DECL(_hw_ata);
-SYSCTL_INT(_hw_ata, OID_AUTO, ata_dma, CTLFLAG_RDTUN, &ata_dma, 0,
- "ATA disk DMA mode control");
-SYSCTL_INT(_hw_ata, OID_AUTO, wc, CTLFLAG_RDTUN, &ata_wc, 0,
- "ATA disk write caching");
-
void
ad_attach(struct ata_device *atadev)
{
--=-=-=--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?xzpn0bdeseu.fsf>