Date: Fri, 20 Jan 2012 19:22:41 -0500 From: Eitan Adler <eadler@freebsd.org> To: Bruce Evans <brde@optusnet.com.au> Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, Hiroki Sato <hrs@freebsd.org>, src-committers@freebsd.org Subject: Re: svn commit: r230354 - head/usr.sbin/makefs Message-ID: <CAF6rxg=UH23TreEMzgZVxO_3GB%2B-K3EL02hOSG2DUb0=V-7UBg@mail.gmail.com> In-Reply-To: <20120121103348.Q1254@besplex.bde.org> References: <201201200138.q0K1cSou016739@svn.freebsd.org> <20120120.123256.1432718473132856309.hrs@allbsd.org> <20120121103348.Q1254@besplex.bde.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Fri, Jan 20, 2012 at 7:13 PM, Bruce Evans <brde@optusnet.com.au> wrote: > I agree. =C2=A0Never fix vendor code. =C2=A0Especially style bugs in it. = =C2=A0Not all > vendor code is in contrib. I'm sure this is a silly question, but why isn't this utility in a contrib/ folder? > In fact, it seems that there there was a very large amount of unused code= , > and this commit only removes the tip of it. =C2=A0There is lots more code= to > initialize msrargs.data in the above, but now msrargs.data is unised too. > This is apparently too complicated for the compiler to see that it is > unused: I had more patches which this conversation is making me hold back on: this code is contributed it doesn't fall under my goal of making the world buildable with gcc46. [snip other fixes to the api] > I don't understand this code well enough to fix it. =C2=A0Fixing it requi= res > understanding whether the unused variable was unused because of another > bug. =C2=A0Another bug seems likely here, since there is so much dead cod= e. > Or maybe I'm just confused, and the dead code is actually undead. =C2=A0I= t > is complicated enough for this to be unclear. I did not just rely on the compiler - I went through the code manually to ensure it was correct. --=20 Eitan Adler Ports committer X11, Bugbusting teams
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAF6rxg=UH23TreEMzgZVxO_3GB%2B-K3EL02hOSG2DUb0=V-7UBg>