Date: Fri, 07 Nov 2014 09:48:02 +0000 From: Steven Hartland <killing@multiplay.co.uk> To: Borja Marcos <borjam@sarenet.es> Cc: freebsd-fs@freebsd.org Subject: Re: ZFS bug: was creating ZIL ignores vfs.zfs.min_auto_ashift, should be ZIL sets improper ashift with AHCI controllers Message-ID: <545C9552.30207@multiplay.co.uk> In-Reply-To: <757B9039-8DF0-4E6A-A036-82A2143D7F45@sarenet.es> References: <B731A922-3F83-4D8E-A4EA-22C5CA8A3850@sarenet.es> <9C91F97841BC4347910F206618BAA3BB9AF327D1@PAIMAIL.pai.local> <545B76EF.6050709@multiplay.co.uk> <21D2A3A9-B6C1-458F-B17F-480251E999AE@sarenet.es> <545BE3E0.4030203@multiplay.co.uk> <757B9039-8DF0-4E6A-A036-82A2143D7F45@sarenet.es>
next in thread | previous in thread | raw e-mail | index | archive | help
This is a multi-part message in MIME format.
--------------040004010503080103060804
Content-Type: text/plain; charset=windows-1252; format=flowed
Content-Transfer-Encoding: 7bit
On 07/11/2014 07:31, Borja Marcos wrote:
> snip...
>
> You are right!
>
> This time I had not altered min_auto_ashift but I had added a quirk to ata_da.c. So it
> correctly used the quirk sector size to adjust ashift.
>
> Seems the bug should be "improper cache file generation for a pool used for boot". I'll
> see if I can run some more tests.
>
I believe the attached is the correct fix, but I've asked upstream as
this test was explicitly added ages ago.
Regards
Steve
--------------040004010503080103060804
Content-Type: text/plain; charset=windows-1252;
name="zpool-cache.patch"
Content-Transfer-Encoding: 7bit
Content-Disposition: attachment;
filename="zpool-cache.patch"
Index: sys/cddl/contrib/opensolaris/uts/common/fs/zfs/spa_config.c
===================================================================
--- sys/cddl/contrib/opensolaris/uts/common/fs/zfs/spa_config.c (revision 274189)
+++ sys/cddl/contrib/opensolaris/uts/common/fs/zfs/spa_config.c (working copy)
@@ -536,8 +536,7 @@ spa_config_update(spa_t *spa, int what)
/*
* Update the global config cache to reflect the new mosconfig.
*/
- if (!spa->spa_is_root)
- spa_config_sync(spa, B_FALSE, what != SPA_CONFIG_UPDATE_POOL);
+ spa_config_sync(spa, B_FALSE, what != SPA_CONFIG_UPDATE_POOL);
if (what == SPA_CONFIG_UPDATE_POOL)
spa_config_update(spa, SPA_CONFIG_UPDATE_VDEVS);
--------------040004010503080103060804--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?545C9552.30207>