Date: Fri, 13 Jun 2014 12:49:34 -0400 From: Glen Barber <gjb@FreeBSD.org> To: Warner Losh <imp@bsdimp.com> Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, Julio Merino <jmmv@freebsd.org>, src-committers@freebsd.org, Nathan Whitehorn <nwhitehorn@freebsd.org> Subject: Re: svn commit: r267332 - head/release Message-ID: <20140613164934.GU1248@hub.FreeBSD.org> In-Reply-To: <D82BB88B-DE3E-4DE0-9935-C2ABDA382784@gmail.com> References: <201406101705.s5AH5gt8007603@svn.freebsd.org> <53973EC7.10306@freebsd.org> <D82BB88B-DE3E-4DE0-9935-C2ABDA382784@gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
[-- Attachment #1 --] On Fri, Jun 13, 2014 at 10:34:50AM -0600, Warner Losh wrote: > > On Jun 10, 2014, at 11:22 AM, Nathan Whitehorn <nwhitehorn@freebsd.org> wrote: > > > On 06/10/14 10:05, Julio Merino wrote: > >> Author: jmmv > >> Date: Tue Jun 10 17:05:41 2014 > >> New Revision: 267332 > >> URL: http://svnweb.freebsd.org/changeset/base/267332 > >> > >> Log: > >> Strip out the test suite from the installation media. > >> This affects the disc1.iso, dvd1.iso and bootonly.iso files. > >> Obtained from: gjb > >> > >> Modified: > >> head/release/Makefile > >> > >> Modified: head/release/Makefile > >> ============================================================================== > >> --- head/release/Makefile Tue Jun 10 17:04:30 2014 (r267331) > >> +++ head/release/Makefile Tue Jun 10 17:05:41 2014 (r267332) > >> @@ -155,7 +155,7 @@ system: packagesystem > >> mkdir -p release > >> cd ${WORLDDIR} && ${IMAKE} installkernel installworld distribution \ > >> DESTDIR=${.OBJDIR}/release WITHOUT_RESCUE=1 WITHOUT_KERNEL_SYMBOLS=1 \ > >> - WITHOUT_PROFILE=1 WITHOUT_SENDMAIL=1 WITHOUT_ATF=1 WITHOUT_LIB32=1 > >> + WITHOUT_PROFILE=1 WITHOUT_SENDMAIL=1 MK_TESTS=no WITHOUT_LIB32=1 > >> # Copy distfiles > > > > Shouldn't this be "WITHOUT_TESTS" or the like? I thought we weren't supposed to set MK_* at the command line. > > We recently started allowing MK_TESTS=no on the command line. In general, all of those WITHOUT_xxx should become MK_xxx=no in release/Makefile. Having the MK_xxxx version isolates us further from (a) the current defaults and (b) config files that turn it to the other direction. > The WITH*_FOO -> MK_FOO change is on my TODO this weekend. I want to run at least one full build before committing it. Glen [-- Attachment #2 --] -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAEBCAAGBQJTmyueAAoJELls3eqvi17QXeUQAKotD9SHVsYKoXGzjWwxVlu9 ebQCy+OC8TppbyJ5bkm+K7sIgryS/X8Iiby1WkT1he1TiTLdU1UY36qjvAEpby+0 kCpkkJMogU9VozwD/+U+zC0LDDWqXE8JZea1H0nppUVsK3JGBSpEvqBa4r50Py2I GELOObjlwmOD6pNt6TsJa91sAv1wpipycO8A8OEeE2wSXD6ARW1WV/tko1tUlgT6 +DEDQLvGj3pkVAHt6gYgfsoK3HNJMzSEJfOV+G71u4cpZ1MsuRzfvVoe3y5QkVQV 7Q8nHrxUlM2sRWdPRsQ7DhS/qBjEwYshUI320PjQ2ZMuJyCoM4YNxyPWavwf1Dm1 THXgW/rRnwSXdoUwrI0Eppaw8YDm6fFM/JzDQ3ri771aW1ejvIlNECLUpVlOLOj5 /UYvcEL/Hd5txVx0fzroTbvPbQmTwSf0bGI4XFK3BAJIn068pS0ExVZ6t8P/8yPE c4guTrVE8ElZPPFqU/Txmmqxfz9Pb5n62bTM0Y3ie94rMP8Igd7tjbnZyq/lbgln ro/a/MtwqfgQXMEu+mcBxI8SQldb3O4/Fa9Xaw1PPWJojgsQkHF0EAJWA0PJaHfl Kj5Ce3iX9I7RsJSBGenw8NmbPrDgJTSNPvST6mwrPImVUHGIw18cloaW3EJXoV1y HxK5cFLu/4aBYP9JGRq2 =ck5c -----END PGP SIGNATURE-----
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20140613164934.GU1248>