Date: Mon, 22 Jun 2026 01:53:32 +0330 From: Faraz Vahedi <kfv@kfv.io> To: Warner Losh <imp@bsdimp.com> Cc: Mark Millard <marklmi@yahoo.com>, Warner Losh <imp@freebsd.org>, src-committers@freebsd.org, dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org, Nuno Teixeira <eduardo@freebsd.org> Subject: Re: git: 28cecfe27964 - main - libc: Restrict ATOMIC_VAR_INIT for C23 conformance Message-ID: <94E5F613-3930-464B-AC10-4943230C2025@kfv.io> In-Reply-To: <CANCZdfpo0mECxiLM9mFV7=6yNZgspcbvzFYyE2hsHeQ1X8p_eA@mail.gmail.com> References: <6a35ddd3.22963.721d614@gitrepo.freebsd.org> <4e902fcf-e79c-47b5-a51f-4881c09f7528@yahoo.com> <CANCZdfpo0mECxiLM9mFV7=6yNZgspcbvzFYyE2hsHeQ1X8p_eA@mail.gmail.com>
index | next in thread | previous in thread | raw e-mail
[-- Attachment #1 --] Hello everyone, My sincere apologies for replying so late and for missing the thread. D57724 looks reasonable, but I would probably just change the gate from __ISO_C_VISIBLE to __STDC_VERSION__. I think that is what I should have done in the first place. That would make more sense for obsolete language constructs, I believe. This way, __ISO_C_VISIBLE is kept solely for API visibility, and strict rules of a specific language mode are checked against the exact mode in use, rather than what API interfaces we have decided to expose. So exposure is not constrained, just determined independently. I think this is the subtle distinction I failed to keep in mind while I was working on the patch. Please let me know what you all think, and again, please accept my apologies for missing both the thread and the review of D57724. Cheers, Faraz P.S. As a minor follow-up, it may be worth revisiting whether gating via __STDC_VERSION__ < 202311L would be preferable to the recently committed __BSD_VISIBLE condition, as it aligns more directly with language standard level rather than exposure of the platform-specific interfaces. [-- Attachment #2 --] -----BEGIN PGP SIGNATURE----- iQIzBAEBCAAdFiEEnunneCmADnpNx8ZMLdpU9MVz/74FAmo4ZGQACgkQLdpU9MVz /76V+hAAxv/sZni8vGTpnrt/K3uulchyTbtzQ9eJsxn0P6MxE8bIsZ4ZdGJtlvU1 H+YphK5cbSn2nXI2xDoog8SgyTkciRen6sYVqEY4Llg100S9yuIsQfdgRtzSn3FX UF+9ZENXKIP/KeIWs30wXl4kxH58TVx48gbGto9hLTcI0RTnSLeh4UQc1ATc82bm 4WSAJv5DgPMG/3mmDQ3NuOiUQNwtbz2vOa0+2ZAKszgJmdJATJEClHEjkt3f4iac aMcKAyddvJ/YBGsuKOPjwGXgyeit6ZpYZoTRInJq++4kFl8OXQv3h7YFMTERCCV1 2sA1Sw0nLM97fEPFs2LXUsn2PBOX+19gHNj63of55Z72gUBmFH+/YaOLsNZXAlCL jljNvxPfMtRYEIQ+RtxgWnzGOJd1lCIVM3+r/jOulLvGRhJLaEwXguYHJeOFzIoH fPoz+hofoMoWxkoDHp42KlDO2XyBDJF5f6rhaAmP8zJ0ckOHYF7LdFC8q3b8GNab oxXqWM4Sq7sJQTk4TQfwPAViEX7K5WHiuCWMG9y0DuUtuAj4Gukw06DUARCczHIg JcxVmh8FbBkAgW+zDNFcr4ITwwSh51TQ+Gp1Bxrr8oft2fwHI+l7JRedMQhwQEz8 I1FIstIlk0O5M+4l6Pd1hFky33elZ4pWX4VW+yTBtv/HhWj4yNs= =AuVf -----END PGP SIGNATURE-----home | help
Want to link to this message? Use this
URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?94E5F613-3930-464B-AC10-4943230C2025>