Date: Thu, 7 Mar 2019 12:43:55 -0800 (PST) From: "Rodney W. Grimes" <freebsd@gndrsh.dnsmgr.net> To: Konstantin Belousov <kib@freebsd.org> Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-stable@freebsd.org, svn-src-stable-12@freebsd.org Subject: Re: svn commit: r344898 - stable/12/share/mk Message-ID: <201903072043.x27KhtYw092243@ gndrsh.dnsmgr.net> In-Reply-To: <201903072040.x27KeeDI055175@repo.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
> Author: kib > Date: Thu Mar 7 20:40:39 2019 > New Revision: 344898 > URL: https://svnweb.freebsd.org/changeset/base/344898 > > Log: > Disable WITH_RETPOLINE on stable/12. > > It is known that clang 7 generates broken ifunc calls when retpoline is > enabled. Since libc uses ifuncs, mark WITH_RETPOLINE as always broken > and disabled. To be removed after clang 8 MFC. > > This is a direct commit to the branch. > > Reported by: many > Tested by: Nikola Mihaylov <c.source.code@gmail.com> > Reviewed by: emaste > Sponsored by: The FreeBSD Foundation Would an UPDATING entry be warranted? > Modified: > stable/12/share/mk/src.opts.mk > > Modified: stable/12/share/mk/src.opts.mk > ============================================================================== > --- stable/12/share/mk/src.opts.mk Thu Mar 7 20:12:50 2019 (r344897) > +++ stable/12/share/mk/src.opts.mk Thu Mar 7 20:40:39 2019 (r344898) > @@ -365,6 +365,9 @@ BROKEN_OPTIONS+=LOADER_UBOOT > BROKEN_OPTIONS+=LOADER_GELI LOADER_LUA > .endif > > +# clang 7.0 > +BROKEN_OPTIONS+=RETPOLINE > + > .if ${__T:Mmips64*} > # profiling won't work on MIPS64 because there is only assembly for o32 > BROKEN_OPTIONS+=PROFILE > > -- Rod Grimes rgrimes@freebsd.org
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201903072043.x27KhtYw092243>