Date: Fri, 16 Aug 2002 15:08:31 +0300 (EEST) From: Iasen Kostov <ikostov@otel.net> To: Maxim Sobolev <max@vega.com> Cc: Julian Elischer <julian@elischer.org>, Maxim Sobolev <sobomax@FreeBSD.ORG>, <hackers@FreeBSD.ORG>, <net@FreeBSD.ORG> Subject: Re: Increasing size of if_flags field in the ifnet structure [patch Message-ID: <20020816150159.T18061-100000@shadowhand.OTEL.net> In-Reply-To: <200208161133.g7GBXnIX005225@vega.vega.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On Fri, 16 Aug 2002, Maxim Sobolev wrote:
> >
> > Please take a look at this patch. It implement 1 more flag to if_flags
> > and ofcourse it increases size of this flag field by using if_ipending
> > which is unused.
>
> There is no much point in this patch, because it will increase size of
> struct ifreq, which means that no ioctl's from older apps will be accepted
> anyway. Therefore, there is no difference between those two, while my
> approach is obviously cleaner.
It does not increase size of struct ifreq.
This is a union not a struct as You see.
union {
struct sockaddr ifru_addr;
struct sockaddr ifru_dstaddr;
struct sockaddr ifru_broadaddr;
short ifru_flags[2];
int ifru_flagslong;
int ifru_metric;
int ifru_mtu;
int ifru_phys;
int ifru_media;
caddr_t ifru_data;
int ifru_cap[2];
} ifr_ifru;
>
> -Maxim
>
> >
> > On Thu, 15 Aug 2002, Julian Elischer wrote:
> >
> > > you cannot break ABIs in 4.x
> > > in 5.x it will probably be ok until (say) 5.1 or something.
> > >
> > >
> > > On Thu, 15 Aug 2002, Maxim Sobolev wrote:
> > >
> > > > Folks,
> > > >
> > > > When implementing ability to switch interface into promisc mode using
> > > > ifconfig(8) I've stumbled into the problem with already exhausted
> > > > space in the `short if_flags' field in the ifnet structure. I need to
> > > > allocate one new flag, while we already have 16 IFF_* flags, and even
> > > > one additional flag which is implemented using currently free
> > > > if_ipending field of the said structure. Attached patch is aimed at
> > > > increasing size of if_flags to 32 bits, as well as to clean-up
> > > > if_ipending abuse. Granted, it will break backward ABI compatibility,
> > > > but IMO it is not a big problem.
> > > >
> > > > Comments and suggestions are greatly appreciated. Thanks!
> > > >
> > > > -Maxim
> > >
> > >
> > > To Unsubscribe: send mail to majordomo@FreeBSD.org
> > > with "unsubscribe freebsd-net" in the body of the message
> > >
> >
>
>
> To Unsubscribe: send mail to majordomo@FreeBSD.org
> with "unsubscribe freebsd-net" in the body of the message
>
To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-net" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20020816150159.T18061-100000>