Date: Fri, 1 Aug 2003 11:42:43 -0700 From: Gordon Tetlow <gordont@gnf.org> To: Bruce Evans <bde@zeta.org.au> Cc: cvs-all@FreeBSD.org Subject: Re: cvs commit: src/rescue/rescue Makefile Message-ID: <20030801184243.GT12582@roark.gnf.org> In-Reply-To: <20030802000356.P1436@gamplex.bde.org> References: <200308010904.h7194W4a061763@repoman.freebsd.org> <20030802000356.P1436@gamplex.bde.org>
next in thread | previous in thread | raw e-mail | index | archive | help
--53TzBEXPl5+8hjUY
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable
On Sat, Aug 02, 2003 at 12:11:56AM +1000, Bruce Evans wrote:
> On Fri, 1 Aug 2003, Gordon Tetlow wrote:
>=20
> > gordon 2003/08/01 02:04:32 PDT
> >
> > FreeBSD src repository
> >
> > Modified files:
> > rescue/rescue Makefile
> > Log:
> > When using crunchgen, blow away MAKEFLAGS. This fixes make -j <#> -P
> > from passing the -P flag to crunchgen which seems to confuse crunchgen
> > horribly.
>=20
> Doesn't also prevent make -j <#> -P from passing the -j <#> flag and any
> other useful flags that may be in MAKEFLAGS?
That's true, but it's only on a single invocation of crunchgen. I should
have been more clear in my commit message.
> > This is the preferable solution to modifing crunchgen to
> > unset the MAKEFLAGS environment variable.
>=20
> Certainly, since unsetting MAKEFLAGS very generally would be more likely
> to lose something important in it.
>=20
> Setting MAKEFLAGS to ${MAKEFLAGS:N-P} might be safe enough to do generall=
y.
I'll test out this solution. There are other flags that are potentially
dangerous (perhaps -v, although I haven't tested it to see if it causes
problems).
-gordon
--53TzBEXPl5+8hjUY
Content-Type: application/pgp-signature
Content-Disposition: inline
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.1 (FreeBSD)
iD8DBQE/KrSjRu2t9DV9ZfsRAojiAKCzOrAvVW74pcAZTPwfL4XsJ2XyMACfU7Jq
EPHZ32o0hrVQdk7Rv2ou6IA=
=Cz2w
-----END PGP SIGNATURE-----
--53TzBEXPl5+8hjUY--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20030801184243.GT12582>