Date: Fri, 22 Jun 2001 09:37:54 -0700 From: "David O'Brien" <obrien@freebsd.org> To: Mike Barcroft <mike@q9media.com> Cc: Mike Heffner <mheffner@vt.edu>, phk@freebsd.org, freebsd-audit@freebsd.org Subject: Re: whois(1) patch Message-ID: <20010622093754.B38146@dragon.nuxi.com> In-Reply-To: <B758EB5A.D6C%mike@q9media.com>; from mike@q9media.com on Fri, Jun 22, 2001 at 12:32:26PM -0400 References: <20010622033201.B506@dragon.nuxi.com> <B758EB5A.D6C%mike@q9media.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On Fri, Jun 22, 2001 at 12:32:26PM -0400, Mike Barcroft wrote: > > You should separate your patches into functionality and style(9). > > I see DES just committed this patch as is, rather than break it into two > > parts as our practices says it should have been. > > Sorry. I'll make sure I do this in future. Thanks! :-) > > You also changed puts() to printf(). Was there a reason for making that > > change? > > style(9): > Use printf(3), not fputs/puts/putchar/whatever; it's faster and usually > cleaner, not to mention avoiding stupid bugs. Ah, I've missed that one. I haven't noticed anyone else do s/puts/printf/g in the name of style(9) before. -- -- David (obrien@FreeBSD.org) To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-audit" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20010622093754.B38146>