Date: Fri, 23 Jan 2015 14:05:52 -0700 From: Ian Lepore <ian@freebsd.org> To: Will Andrews <will@freebsd.org> Cc: Davide Italiano <davide@freebsd.org>, "svn-src-head@freebsd.org" <svn-src-head@freebsd.org>, "svn-src-all@freebsd.org" <svn-src-all@freebsd.org>, "src-committers@freebsd.org" <src-committers@freebsd.org> Subject: Re: svn commit: r277570 - head/usr.bin/vmstat Message-ID: <1422047152.1038.25.camel@freebsd.org> In-Reply-To: <20150123205617.GB56104@sol.firepipe.net> References: <201501231618.t0NGIeDv057991@svn.freebsd.org> <CACYV=-HthyZ061GSs_2=mNXa676we9MqSNVPcWRXur_Z6zD1xA@mail.gmail.com> <20150123205617.GB56104@sol.firepipe.net>
next in thread | previous in thread | raw e-mail | index | archive | help
On Fri, 2015-01-23 at 13:56 -0700, Will Andrews wrote: > On Fri, Jan 23, 2015 at 11:23:57AM -0800, Davide Italiano wrote: > > What's the rationale behind this change? > > The rationale was to match the clock used to the name (and implied intent) > of the variables used to store/manipulate the data. > > It's possible that 'uptime' is entirely the wrong term in vmstat, in which > case the naming used elsewhere in vmstat needs to be changed too. > It seems like there's a good chance this is a step backwards. In the old days if you wanted a monotonic clock, uptime was your only option. Eventually we implemented clock_gettime() and CLOCK_MONOTONIC and likely someone changed the calls in vmstat but perhaps not related variable names. So now we've gone back to the wrong clock to match the old variable names. (I don't see anything in the vmstat manpage about actually displaying or using uptime values at all.) -- Ian
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?1422047152.1038.25.camel>