Date: Thu, 17 Feb 2005 21:05:04 +0000 (UTC) From: Warner Losh <imp@FreeBSD.org> To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org Subject: cvs commit: src/sys/dev/pccard pccard_cis.c Message-ID: <200502172105.j1HL54rD048712@repoman.freebsd.org>
next in thread | raw e-mail | index | archive | help
imp 2005-02-17 21:05:04 UTC
FreeBSD src repository
Modified files:
sys/dev/pccard pccard_cis.c
Log:
memspace is set to some value by masking off bits. When these bits
are equal to PCCARD_TPCE_FS_MEMSPACE_NONE, memspace will be zero, so
testing for this case inside of the if statement results in dead code.
We'd fail to set a value to zero that's already zero (since it is
initialized to 0 indirectly) with this code being there. Well, except
in the very rare case that we have a card that has a defualt entry
that includes a memory space followed by one that has no memory space
(these are extremely rare, I don't recall ever having seen one :-).
Fix this by setting num_memspace to 0 in a more appropriate place.
Submitted by: Coverity Prevent analysis tool
Revision Changes Path
1.31 +3 -4 src/sys/dev/pccard/pccard_cis.c
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200502172105.j1HL54rD048712>