Date: Sat, 24 Oct 2020 19:38:06 -0600 From: Warner Losh <imp@bsdimp.com> To: Ed Maste <emaste@freebsd.org> Cc: "Alexander V. Chernikov" <melifaro@ipfw.ru>, Hans Petter Selasky <hps@selasky.org>, Alexey Dokuchaev <danfe@freebsd.org>, "src-committers@freebsd.org" <src-committers@freebsd.org>, "svn-src-all@freebsd.org" <svn-src-all@freebsd.org>, "svn-src-head@freebsd.org" <svn-src-head@freebsd.org> Subject: Re: svn commit: r366993 - head/sys/net Message-ID: <CANCZdfpKk_2CSxt6tK=zTaHF4LwxjPxNjdEZD53u2jOTfvVBSA@mail.gmail.com> In-Reply-To: <CAPyFy2Coiyz1CYGGLD3QS1M-6Q4Hc38WNcXA%2BKvRbuTAhmMvcA@mail.gmail.com> References: <202010241023.09OANMcL075640@repo.freebsd.org> <20201024125206.GB38000@FreeBSD.org> <999a005e-1ef8-3c45-fb07-94a3b6ebce1b@selasky.org> <317231603546378@mail.yandex.ru> <CANCZdfq8NH=rspaugts=W0Uu183pDcVvOK8oGh6kCvfpkM-=Ww@mail.gmail.com> <CAPyFy2Coiyz1CYGGLD3QS1M-6Q4Hc38WNcXA%2BKvRbuTAhmMvcA@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On Sat, Oct 24, 2020 at 7:20 PM Ed Maste <emaste@freebsd.org> wrote: > On Sat, 24 Oct 2020 at 11:27, Warner Losh <imp@bsdimp.com> wrote: > > > >> Given we already have nice .clang-format, that does most of the job, > maybe it's worth considering looking into tweaking it further to fix this > part? > >> It would be nice if we could finally offload all formatting issues to > the tool and focus on the actual code :-) > > > > It would be nice if it produced one of the style(9) acceptable formats > without disrupting things already acceptable. That's been the big problem > with the tweaks to date... some things are fixed, others break. It's > getting a lot closer, though > > Upstream clang-format comes with a script that can integrate with git, > adding a `git clang-format` command. It will apply formatting to > modified lines, leaving unchanged ones alone. > As long as it's optional... Warner
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CANCZdfpKk_2CSxt6tK=zTaHF4LwxjPxNjdEZD53u2jOTfvVBSA>