Date: Mon, 17 Oct 2011 16:13:15 -0400 From: Arnaud Lacombe <lacombar@gmail.com> To: Garrett Cooper <yanegomi@gmail.com> Cc: Nali Toja <nalitoja@gmail.com>, Alexander Best <arundel@freebsd.org>, Poul-Henning Kamp <phk@phk.freebsd.dk>, FreeBSD Current <freebsd-current@freebsd.org>, Nikolay Denev <ndenev@gmail.com> Subject: Re: [RFC] Prepend timestamp in msgbuf Message-ID: <CACqU3MXUYOCZTSvXdLhKdbDg2Mz053m8xFK0bsrAk2bdiwRxzA@mail.gmail.com> In-Reply-To: <CAGH67wRczmTTFkxb2cpmYoywRcRnk%2BgTx32Zy-bzmBu_JxV-_w@mail.gmail.com> References: <20111014085609.GA3799@freebsd.org> <40448.1318582809@critter.freebsd.dk> <20111014092445.GA11785@freebsd.org> <20111014093406.GA13981@freebsd.org> <8662jrlor0.fsf@gmail.com> <CACqU3MUznrsT0UD5Dk5sWU%2Bz7cVSPO32GwiubL2qee15=8-cHw@mail.gmail.com> <20111017180111.GA91732@freebsd.org> <CACqU3MUafjo4xRgBtxW8WnSc=b73an7Mc3w0zu=n4ehyv9vdjA@mail.gmail.com> <CAGH67wRczmTTFkxb2cpmYoywRcRnk%2BgTx32Zy-bzmBu_JxV-_w@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
Hi, On Mon, Oct 17, 2011 at 3:38 PM, Garrett Cooper <yanegomi@gmail.com> wrote: > On Mon, Oct 17, 2011 at 12:27 PM, Arnaud Lacombe <lacombar@gmail.com> wro= te: >> Hi, >> >> On Mon, Oct 17, 2011 at 2:01 PM, Alexander Best <arundel@freebsd.org> wr= ote: >>> On Fri Oct 14 11, Arnaud Lacombe wrote: >>> [...] >>> >>> cc -c -O -pipe -march=3Dcore2 -std=3Dc99 -g -Wall -Wredundant-decls -Wn= ested-externs -Wstrict-prototypes -Wmissing-prototypes -Wpointer-arith -Win= line -Wcast-qual -Wundef -Wno-pointer-sign -Wmissing-include-dirs -nostdinc= =A0-I. -I/usr/git-freebsd-head/sys -I/usr/git-freebsd-head/sys/contrib/alt= q -D_KERNEL -DHAVE_KERNEL_OPTION_HEADERS -include opt_global.h -fno-common = -finline-limit=3D8000 --param inline-unit-growth=3D100 --param large-functi= on-growth=3D1000 =A0-fno-omit-frame-pointer -mno-sse -mcmodel=3Dkernel -mno= -red-zone -mno-mmx -msoft-float -fno-asynchronous-unwind-tables -ffreestand= ing -fformat-extensions -fdiagnostics-show-option -fstack-protector -Werror= =A0/usr/git-freebsd-head/sys/kern/subr_msgbuf.c >>> cc1: warnings being treated as errors >>> /usr/git-freebsd-head/sys/kern/subr_msgbuf.c: In function 'msgbuf_do_ad= dchar': >>> /usr/git-freebsd-head/sys/kern/subr_msgbuf.c:171: warning: format '%d' = expects type 'int', but argument 4 has type 'time_t' [-Wformat] >>> *** Error code 1 >>> >>> Stop in /usr/obj/usr/git-freebsd-head/sys/ARUNDEL. >>> *** Error code 1 >>> >>> Stop in /usr/git-freebsd-head. >>> *** Error code 1 >>> >>> Stop in /usr/git-freebsd-head. >>> >> FreeBSD has no time_t PRI... macros in any <machine/_inttypes.h>, >> eventually cast it to `long'. >> >> Btw, I appreciate the very clear message of yours, no "Hi", no >> signature, no idea what "ARUNDEL" is, and especially no details on >> which architecture you are attempting to build, which should be, I >> assume, LP64 ;-) > > =A0 =A0time_t maps to int32_t on i386 and int64_t on amd64 (at least), so > you should be able to use "%zd" in the format string as the type is > variable width depending on the architecture. > make sense. Thanks, - Arnaud
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CACqU3MXUYOCZTSvXdLhKdbDg2Mz053m8xFK0bsrAk2bdiwRxzA>