Skip site navigation (1)Skip section navigation (2)
Date:      Sun, 12 Mar 2017 07:07:05 -0700
From:      Ngie Cooper <yaneurabeya@gmail.com>
To:        =?utf-8?Q?Dag-Erling_Sm=C3=B8rgrav?= <des@des.no>
Cc:        src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org
Subject:   Re: svn commit: r308996 - head/lib/libfetch
Message-ID:  <92F67C24-E539-4810-9014-DCC019DD0CBB@gmail.com>
In-Reply-To: <86shmid9ct.fsf@desk.des.no>
References:  <201611221330.uAMDU7fg052989@repo.freebsd.org> <93505FD7-FB42-4BD5-834C-6F73EFD9B1CF@gmail.com> <86shmid9ct.fsf@desk.des.no>

next in thread | previous in thread | raw e-mail | index | archive | help

> On Mar 12, 2017, at 04:26, Dag-Erling Sm=C3=B8rgrav <des@des.no> wrote:
>=20
> "Ngie Cooper (yaneurabeya)" <yaneurabeya@gmail.com> writes:
>> Hi Bjoern,
>=20
> No, that was my father :)

:D..

>>    Shouldn=E2=80=99t this be strrchr instead of strchr since you=E2=80=99=
re
>> scanning for the service from the right side of the host,
>> e.g. =E2=80=9Cfoo:service=E2=80=9D or =E2=80=9C[::1]:service=E2=80=9D? Th=
is code would match index 3
>> in the first example, but it would match index 2 in the second
>> example.
>=20
> Correct, although it may be slightly more complicated, which is why I
> didn't immediately jump on it when bz@ pointed it out.  I'm working on
> it right now.

Awesome! Great teamwork!
-Ngie=



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?92F67C24-E539-4810-9014-DCC019DD0CBB>