Date: Sat, 29 Aug 2020 14:49:26 +0000 From: bugzilla-noreply@freebsd.org To: net@FreeBSD.org Subject: [Bug 248958] pptpd + vlan panic Message-ID: <bug-248958-7501-GOxe9zgyIC@https.bugs.freebsd.org/bugzilla/> In-Reply-To: <bug-248958-7501@https.bugs.freebsd.org/bugzilla/> References: <bug-248958-7501@https.bugs.freebsd.org/bugzilla/>
next in thread | previous in thread | raw e-mail | index | archive | help
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D248958 --- Comment #3 from Gleb Smirnoff <glebius@FreeBSD.org> --- > https://reviews.freebsd.org/D26226 Right now reviews.freebsd.org is returning 502 for me, so I can't comment there. I believe the patch is incorrect there. In the new epoch synced network sta= ck the packet flow of netgraph shall all be covered by epoch. And eventually netgraph internal synchronization shall be converted to epoch. Thus, this is responsibility of an entrance nodes to enter the epoch, not the exit nodes. ng_socket does that. However, there is one peculiarity, see r358193. In this particular case what happens in ng_pppoe is that control message ca= ll (not covered by epoch) sends a packet down the node, which should be covere= d by epoch. So, this is ng_pppoe's ng_pppoe_rcvmsg() that needs to enter epoch u= ntil some better solution is devised to address the problem described in r358193. --=20 You are receiving this mail because: You are the assignee for the bug.=
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?bug-248958-7501-GOxe9zgyIC>