Skip site navigation (1)Skip section navigation (2)
Date:      Mon, 8 Jan 2018 13:43:12 +0000 (UTC)
From:      Fabien Thomas <fabient@FreeBSD.org>
To:        src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org
Subject:   svn commit: r327696 - head/sys/opencrypto
Message-ID:  <201801081343.w08DhCjV094277@repo.freebsd.org>

next in thread | raw e-mail | index | archive | help
Author: fabient
Date: Mon Jan  8 13:43:12 2018
New Revision: 327696
URL: https://svnweb.freebsd.org/changeset/base/327696

Log:
  Fix uninitialized crp_retw_id when using asynchronous crypto drivers
  with defered callbacks.
  
  Submitted by:	emeric.poupon@stormshield.eu
  Reported by:	mav@
  Reviewed by:	fabient@

Modified:
  head/sys/opencrypto/crypto.c

Modified: head/sys/opencrypto/crypto.c
==============================================================================
--- head/sys/opencrypto/crypto.c	Mon Jan  8 13:19:15 2018	(r327695)
+++ head/sys/opencrypto/crypto.c	Mon Jan  8 13:43:12 2018	(r327696)
@@ -896,11 +896,12 @@ crypto_dispatch(struct cryptop *crp)
 		binuptime(&crp->crp_tstamp);
 #endif
 
+	crp->crp_retw_id = crp->crp_sid % crypto_workers_num;
+
 	if (CRYPTOP_ASYNC(crp)) {
 		if (crp->crp_flags & CRYPTO_F_ASYNC_KEEPORDER) {
 			struct crypto_ret_worker *ret_worker;
 
-			crp->crp_retw_id = crp->crp_sid % crypto_workers_num;
 			ret_worker = CRYPTO_RETW(crp->crp_retw_id);
 
 			CRYPTO_RETW_LOCK(ret_worker);



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201801081343.w08DhCjV094277>