Date: Thu, 8 Aug 2019 02:46:56 -0700 From: Enji Cooper <yaneurabeya@gmail.com> To: Li-Wen Hsu <lwhsu@FreeBSD.org> Cc: Mark Johnston <markj@freebsd.org>, src-committers <src-committers@freebsd.org>, svn-src-all <svn-src-all@freebsd.org>, svn-src-head@freebsd.org Subject: Re: svn commit: r350512 - head/tests/sys/kern Message-ID: <50736BCD-21A8-4E59-92F7-DBFE60E652DA@gmail.com> In-Reply-To: <CAKBkRUwkQB6d=xyYMGo44XpAR36LRq2VrMokoZNv4yZUakZ2iQ@mail.gmail.com> References: <201908011819.x71IJG0M076399@repo.freebsd.org> <20190807202732.GD1377@raichu> <CAKBkRUwkQB6d=xyYMGo44XpAR36LRq2VrMokoZNv4yZUakZ2iQ@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
> On Aug 7, 2019, at 2:04 PM, Li-Wen Hsu <lwhsu@FreeBSD.org> wrote: >=20 > On Thu, Aug 8, 2019 at 4:27 AM Mark Johnston <markj@freebsd.org = <mailto:markj@freebsd.org>> wrote: >>=20 >> On Thu, Aug 01, 2019 at 06:19:16PM +0000, Li-Wen Hsu wrote: >>> Author: lwhsu >>> Date: Thu Aug 1 18:19:16 2019 >>> New Revision: 350512 >>> URL: https://svnweb.freebsd.org/changeset/base/350512 >>>=20 >>> Log: >>> Only skip test cases sometimes failing in CI when they are running = in CI >>>=20 >>> Suggested by: jhb >>> Sponsored by: The FreeBSD Foundation >>=20 >> This seems to break running the tests manually; atf dies because the >> "ci" variable is not defined. I have to use an invocation like this = to >> avoid that: >>=20 >> $ kyua -v test_suites.FreeBSD.ci=3Dfalse test ptrace_test >>=20 >> I suspect that share/mk/suite.test.mk needs to be augmented somehow = to >> set this variable to "false" by default, so that the CI = infrastructure >> can override that. >=20 > Thanks for catching this! I feel that the better approach is using > function that gets this variable with default value, for keeping > things simple. This is the right API to use: atf_tc_get_config_var_as_bool_wd(tc, variable_name, default_value); Just set the default to `false`. HTH, -Enji=
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?50736BCD-21A8-4E59-92F7-DBFE60E652DA>