Skip site navigation (1)Skip section navigation (2) 
Date:      Thu, 21 May 2020 12:43:34 +0000 (UTC)
From:      Konstantin Belousov <kib@FreeBSD.org>
To:        src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-releng@freebsd.org
Subject:   svn commit: r361329 - releng/11.4/sys/kern
Message-ID:  <202005211243.04LChYQj069799@repo.freebsd.org>
next in thread | raw e-mail | index | archive | help 
Author: kib
Date: Thu May 21 12:43:34 2020
New Revision: 361329
URL: https://svnweb.freebsd.org/changeset/base/361329

Log:
  MFC r361037, r361056:
  Fix spurious ENOTCONN from closed unix domain socket other' side.
  
  Approved by: re (gjb)

Modified:
  releng/11.4/sys/kern/uipc_socket.c
Directory Properties:
  releng/11.4/   (props changed)

Modified: releng/11.4/sys/kern/uipc_socket.c
==============================================================================
--- releng/11.4/sys/kern/uipc_socket.c	Thu May 21 11:14:13 2020	(r361328)
+++ releng/11.4/sys/kern/uipc_socket.c	Thu May 21 12:43:34 2020	(r361329)
@@ -1565,8 +1565,9 @@ restart:
 				m = so->so_rcv.sb_mb;
 				goto dontblock;
 			}
-		if ((so->so_state & (SS_ISCONNECTED|SS_ISCONNECTING)) == 0 &&
-		    (so->so_proto->pr_flags & PR_CONNREQUIRED)) {
+		if ((so->so_state & (SS_ISCONNECTING | SS_ISCONNECTED |
+		    SS_ISDISCONNECTING | SS_ISDISCONNECTED)) == 0 &&
+		    (so->so_proto->pr_flags & PR_CONNREQUIRED) != 0) {
 			SOCKBUF_UNLOCK(&so->so_rcv);
 			error = ENOTCONN;
 			goto release;
@@ -3516,8 +3517,17 @@ soisdisconnected(struct socket *so)
 	 * SOCKBUF_LOCK(&so->so_rcv) are the same.
 	 */
 	SOCKBUF_LOCK(&so->so_rcv);
-	so->so_state &= ~(SS_ISCONNECTING|SS_ISCONNECTED|SS_ISDISCONNECTING);
+
+	/*
+	 * There is at least one reader of so_state that does not
+	 * acquire socket lock, namely soreceive_generic().  Ensure
+	 * that it never sees all flags that track connection status
+	 * cleared, by ordering the update with a barrier semantic of
+	 * our release thread fence.
+	 */
 	so->so_state |= SS_ISDISCONNECTED;
+	atomic_thread_fence_rel();
+	so->so_state &= ~(SS_ISCONNECTING|SS_ISCONNECTED|SS_ISDISCONNECTING);
 	socantrcvmore_locked(so);
 	SOCKBUF_LOCK(&so->so_snd);
 	sbdrop_locked(&so->so_snd, sbused(&so->so_snd));

Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?202005211243.04LChYQj069799>