Date: Thu, 23 May 2024 11:05:57 -0500 From: Mike Karels <mike@karels.net> To: Baptiste Daroussin <bapt@freebsd.org> Cc: Michael Osipov <michaelo@freebsd.org>, src-committers@freebsd.org, dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org Subject: Re: git: aa48259f3371 - main - periodic.conf: remove long deprecated security_daily_compat_var() Message-ID: <1AE302C8-5EED-4644-8900-6D8B91326183@karels.net> In-Reply-To: <ov7t74svffzkfas6z42yyz42hvqjfsoozwinp3rqvzumcq562t@ifp32cuj2bem> References: <202405030740.4437eWUC034126@gitrepo.freebsd.org> <mecrmnhbuuzhha7k55zke4vl37cbtlztpu26rmujpaey5afx6x@ioljshqcbmw2> <648BD801-F3C0-40DD-B500-CB71177A6748@karels.net> <61c568fb-7e9d-4445-9d91-0830975bb54b@FreeBSD.org> <ov7t74svffzkfas6z42yyz42hvqjfsoozwinp3rqvzumcq562t@ifp32cuj2bem>
next in thread | previous in thread | raw e-mail | index | archive | help
On 23 May 2024, at 10:14, Baptiste Daroussin wrote: > On Thu 23 May 14:34, Michael Osipov wrote: >> On 2024-05-23 14:10, Mike Karels wrote: >>> On 22 May 2024, at 10:07, Baptiste Daroussin wrote: >>> >>>> On Fri 03 May 07:40, Michael Osipov wrote: >>>>> The branch main has been updated by michaelo: >>>>> >>>>> URL: https://cgit.FreeBSD.org/src/commit/?id=3Daa48259f337100e79933= d660fec8856371f761ed >>>>> >>>>> commit aa48259f337100e79933d660fec8856371f761ed >>>>> Author: Michael Osipov <michaelo@FreeBSD.org> >>>>> AuthorDate: 2024-04-15 11:05:17 +0000 >>>>> Commit: Michael Osipov <michaelo@FreeBSD.org> >>>>> CommitDate: 2024-05-03 07:38:55 +0000 >>>>> >>>>> periodic.conf: remove long deprecated security_daily_compat_va= r() >>>>> >>>>> This function is documented to be gone in after 11. Time to re= move this >>>>> compat shim. >>>>> >>>>> PR: 275296 >>>>> Reviewed by: jrm (mentor) >>>>> MFC after: 1 month >>>>> Differential Revision: https://reviews.freebsd.org/D44796 >>>> >>>> this broke pkg's periodic script, I would have appreciated a heads u= p to give me >>>> time to prepare a release compatible prior this commit. >>>> >>>> This also breaks some ports. >>>> >>>> Bapt >>> >>> This produces almost a dozen failure messages in the daily security e= mail. >>> Given that the deprecated function was still in use, it should not be= removed. >>> Michael, please revert this. >> >> Salut Baptiste, >> Hi Mike, >> >> this is surprising that is it still in use although clear marked as >> deprecated after 11. Though, Baptiste has pushed a new pkg release yes= terday >> [1] and only main is affected, do you still prefer to revert this comm= it >> (for now)? >> >> @bapt, can you name the affected ports and report a PR, so we can trac= k >> them? >> > > This was in use beside the deprecation, because pkg for one is supposed= to > support as many version of freebsd as possible so we had to keep the de= precation > notice. > > I have released a new version of pkg without it and merged that version= in > quarterly branches, so even if it gets MFCed we should be safe. > > I was scared more ports where keeping for the same reason the deprecate= d code, I > span the ports tree itself and found one port which I fixed straight aw= ay, I > also did a deep analysis of the any port which plist contains etc/perio= dic, > I extracted all their sources and I found nothing. > > so I think we are safe now. I don't think we should revert. > > Best regards, > Bapt OK, I'll withdraw my request to revert if we're confident that there are = no stragglers. Mike
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?1AE302C8-5EED-4644-8900-6D8B91326183>