Date: Mon, 19 Aug 2013 14:13:32 +0200 From: Andre Oppermann <andre@freebsd.org> To: Davide Italiano <davide@freebsd.org> Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r254520 - in head/sys: kern sys Message-ID: <52120BEC.4050604@freebsd.org> In-Reply-To: <CACYV=-GUnHCdiW0ST_dvERLqgZ4yM9oD3ikmU-zPUz9nQueYdw@mail.gmail.com> References: <201308191116.r7JBGsc6065793@svn.freebsd.org> <CACYV=-GUnHCdiW0ST_dvERLqgZ4yM9oD3ikmU-zPUz9nQueYdw@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On 19.08.2013 13:23, Davide Italiano wrote:
> On Mon, Aug 19, 2013 at 1:16 PM, Andre Oppermann <andre@freebsd.org> wrote:
>> Modified: head/sys/sys/mbuf.h
>> ==============================================================================
>> --- head/sys/sys/mbuf.h Mon Aug 19 11:08:36 2013 (r254519)
>> +++ head/sys/sys/mbuf.h Mon Aug 19 11:16:53 2013 (r254520)
>> @@ -200,7 +200,7 @@ struct mbuf {
>> /* 0x00008000 free */
>> #define M_VLANTAG 0x00010000 /* ether_vtag is valid */
>> #define M_PROMISC 0x00020000 /* packet was not for us */
>> -#define M_NOFREE 0x00040000 /* do not free mbuf, embedded in cluster */
>> + /* 0x00040000 free */
>
> I think you should just use M_UNUSED or something similar here for
> consistency, like it's happening in td_pflags (sys/sys/proc.h), e.g.:
>
> #define TDP_UNUSED9 0x00000100 /* --available-- */
There's a couple of more changes upcoming that will take care of it.
--
Andre
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?52120BEC.4050604>