Date: Tue, 29 Jan 2008 22:27:47 +0000 (GMT) From: Robert Watson <rwatson@FreeBSD.org> To: Julian Elischer <julian@elischer.org> Cc: Daniel Eischen <deischen@freebsd.org>, Gary Stanley <gary@velocity-servers.net>, freebsd-threads@freebsd.org Subject: Re: threads/119920: fork broken in libpthread Message-ID: <20080129222455.T53151@fledge.watson.org> In-Reply-To: <479E3079.3000803@elischer.org> References: <200801240850.m0O8o2JQ023500@freefall.freebsd.org> <4798564B.7070500@elischer.org> <Pine.GSO.4.64.0801240957550.16059@sea.ntplx.net> <20080128185830.B56811@fledge.watson.org> <479E3079.3000803@elischer.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Mon, 28 Jan 2008, Julian Elischer wrote: >>>> dan what IS the fix for this? I assume you must have fixed it in >>>> -current/7 >>> >>> You want cvs diff -u -r1.126 -r1.128 src/lib/libkse/thread/thr_kern.c. The >>> WARNS'ify diffs are not necessary, so it should look something like shown >>> below. Probably an MFC of all of libkse (minus jasone's malloc changes) >>> should be done to -7 and -6. >> >> Should the patch be considered for an errata notice for 6.x? Should we be >> trying to MFC this to 7.x for inclusion with 7.0 or does it need more time >> to shake out and should potentially be a 7.0 errata notice or just appear >> in 7.1? > > yes and yes and no If the fix is going to ship in 7.0 and hasn't yet been MFC'd, that needs to happen ASAP. Could someone forward the patch/etc over to re@ for approval? The procedure for doing an errata patch is basically that whoever is proposing the errata patch needs to e-mail a patch, or multiple patches if it's different for different branches, a proposed branch list, and as much of a completed errata notice template as possible (impact, etc) to re@ for review. Once re@ is OK that it's ready to go, it will get sent over to secteam@ to be put into production, binary updates generated, etc. If in doubt about which branches, drop e-mail to secteam@ to ask which are supported, etc. At this point we would probably not advise doing the errata patch before 7.0 is released, so priority should go to preparing any patches that need to go out with 7.0. Thanks, Robert N M Watson Computer Laboratory University of Cambridge
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20080129222455.T53151>