Date: Fri, 2 Jan 2004 17:11:49 -0600 From: Juli Mallett <jmallett@FreeBSD.org> To: Sam Leffler <sam@errno.com> Cc: John Baldwin <jhb@freebsd.org> Subject: Re: PERFORCE change 44709 for review Message-ID: <20040102231149.GA69929@FreeBSD.org> In-Reply-To: <200401021513.38759.sam@errno.com> References: <200401022204.i02M4ob5010556@repoman.freebsd.org> <200401021513.38759.sam@errno.com>
next in thread | previous in thread | raw e-mail | index | archive | help
* Sam Leffler <sam@errno.com> [ Date: 2004-01-02 ] [ w.r.t. Re: PERFORCE change 44709 for review ] > On Friday 02 January 2004 02:04 pm, John Baldwin wrote: > > http://perforce.freebsd.org/chv.cgi?CH=44709 > > > > Change 44709 by jhb@jhb_blue on 2004/01/02 14:04:27 > > > > Bah, stupid bug. > > > > Affected files ... > > > > .. //depot/projects/smpng/sys/modules/crash/crash.c#8 edit > > > > Differences ... > > > > ==== //depot/projects/smpng/sys/modules/crash/crash.c#8 (text+ko) ==== > > > > @@ -234,9 +234,9 @@ > > break; > > case 18: > > bzero(&test1_mtx, sizeof(test1_mtx)); > > - bzero(&test1_mtx, sizeof(test2_mtx)); > > + bzero(&test2_mtx, sizeof(test2_mtx)); > > mtx_init(&test1_mtx, "test1", NULL, MTX_DEF); > > - mtx_init(&test1_mtx, "test2", NULL, MTX_DEF | > > + mtx_init(&test2_mtx, "test2", NULL, MTX_DEF | > > MTX_RECURSE); > > #define TRYLOCK_TEST(lock, descr) do { \ > > status = mtx_trylock((lock)); \ > > Bah bah, bogus assertions. Agreed. I want something to *initialize* these things. I hate one bit of code I have at work: sc->[all fields] = [appropriate values for fields] bzero(&sc->mtx, sizeof sc->mtx); mtx_init(&sc->mtx, "blah", NULL, MTX_DEF); *shrug* -- juli mallett. email: jmallett@freebsd.org; efnet: juli; aim: bsdflata; you can't get me to burn out though you try to break my spirit and me.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20040102231149.GA69929>