Date: Thu, 22 Oct 2015 17:21:24 -0700 From: Bryan Drewery <bdrewery@FreeBSD.org> To: Ian Lepore <ian@freebsd.org> Cc: "src-committers@freebsd.org" <src-committers@freebsd.org>, "svn-src-all@freebsd.org" <svn-src-all@freebsd.org>, "svn-src-head@freebsd.org" <svn-src-head@freebsd.org> Subject: Re: svn commit: r289778 - head/share/mk Message-ID: <6847681E-3E85-40B9-BF9D-2FF4C6DE4AC9@FreeBSD.org> In-Reply-To: <232D9171-D360-4110-8682-6B371D9F9CAC@FreeBSD.org> References: <201510222341.t9MNfuNK007465@repo.freebsd.org> <1445558386.14963.38.camel@freebsd.org> <232D9171-D360-4110-8682-6B371D9F9CAC@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
> On Oct 22, 2015, at 17:18, Bryan Drewery <bdrewery@FreeBSD.org> wrote: >=20 >=20 >=20 >>> On Oct 22, 2015, at 16:59, Ian Lepore <ian@freebsd.org> wrote: >>>=20 >>> On Thu, 2015-10-22 at 23:41 +0000, Bryan Drewery wrote: >>> Author: bdrewery >>> Date: Thu Oct 22 23:41:56 2015 >>> New Revision: 289778 >>> URL: https://svnweb.freebsd.org/changeset/base/289778 >>>=20 >>> Log: >>> For SUBDIR_PARALLEL, when doing 'make clean*' or 'make obj' there >>> is no need to >>> respect SUBDIR_DEPEND_* or .WAIT. >>>=20 >>> MFC after: 2 weeks >>> Sponsored by: EMC / Isilon Storage Division >>=20 >> This doesn't feel so safe. People override these targets and do who >> -knows-what with them. The clean* seems especially risky since it will >> match targets in end-user makefiles that you don't even know about. I can also not apply to SUBDIR_TARGETS which is the user-defined targets lis= t. (Misspelled and should be LOCAL_SUBDIR_TARGETS) >>=20 >> -- Ian >=20 > I can limit it to src tree builds if you want. >=20 > I cannot imagine any situation where "clean<something>" depends on another= directory going first.=20 >=20 > Similarly it makes sense to always build subdirs in parallel with 'obj' an= d I would argue 'clean*' too, regardless of SUBDIR_PARALLEL. I only just rea= lized that. Yes there are mkdir -p and rm -f races, but we have not added an= y dependencies because of these as is.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?6847681E-3E85-40B9-BF9D-2FF4C6DE4AC9>