Date: Fri, 09 Sep 2016 09:06:27 +0000 From: bugzilla-noreply@freebsd.org To: freebsd-bugs@FreeBSD.org Subject: [Bug 211823] [patch] fsck_ffs incorrectly failing in check_cgmagic Message-ID: <bug-211823-8-lwt9nmaibO@https.bugs.freebsd.org/bugzilla/> In-Reply-To: <bug-211823-8@https.bugs.freebsd.org/bugzilla/> References: <bug-211823-8@https.bugs.freebsd.org/bugzilla/>
next in thread | previous in thread | raw e-mail | index | archive | help
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D211823 Konstantin Belousov <kib@FreeBSD.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kib@FreeBSD.org, | |mckusick@mckusick.com --- Comment #1 from Konstantin Belousov <kib@FreeBSD.org> --- I do not see how this patch can be right. You strip off high 16 bits from = the superblock' fs_ipg value and then compare truncated value to UFS1' niblk cylgroup value. This is plain wrong. For UFS1, fs_ipg must be less than 2^15, so the values fit. I have no idea what OpenBSD does there, but this is not how FreeBSD UFS operates. I suspect that binary layout of superblock or cg header on OpenB= SD is different. --=20 You are receiving this mail because: You are the assignee for the bug.=
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?bug-211823-8-lwt9nmaibO>